Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling issues in the debug hover #6887

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Styling issues in the debug hover #6887

merged 1 commit into from
Jan 16, 2020

Conversation

kaiyue0329
Copy link
Contributor

Fixes #6278

What it does

  • Prevent the debug hover from overflowing into the debug console
  • There is no longer a scrollbar overlapping the menu options

How to test

Review checklist

Reminder for reviewers

- Add overflow-y: auto to fix the overflow issue of the debug hover
- The scrollbar on the left side of the debug hover is no longer there

Signed-off-by: Kaiyue Pan <[email protected]>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes and could not reproduce the problem any longer, nice job! 👍

@akosyakov akosyakov added the debug issues that related to debug functionality label Jan 15, 2020
@vince-fugnitto vince-fugnitto merged commit 815cb8b into eclipse-theia:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[debug] Styling issues in the debug hover
3 participants