[DRAFT] fetch tasks by type and schema version #5348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This pull request adds the support of fetching tasks by type and schema version to the plugins API. - resolved eclipse-theia#5432 Signed-off-by: elaihau <[email protected]>
elaihau
commented
Jun 3, 2019
| const tasks = [...this.taskService.getConfiguredTasks(), ...(await this.taskService.getProvidedTasks())]; | ||
| if (taskType) { | ||
| found = tasks.filter(t => { | ||
| if (ContributedTaskConfiguration.is(t)) { |
There was a problem hiding this comment.
The reason that I am creating a DRAFT PR is that ContributedTaskConfiguration.is() is buggy, as @RomanNikitenko pointed out, we should have a more reliable way to check which tasks are contributed which are not.
There was a problem hiding this comment.
@elaihau thank you for your support, I'm going to complete my current issue and review the PR
There was a problem hiding this comment.
@RomanNikitenko yes I updated this PR on my local branch to adapt to the recent changes in task extension.
elaihau
changed the title
|
re-implemented in #6058. closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: elaihau [email protected]