Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WebviewPanel.reveal() #4787

Closed
wants to merge 4 commits into from
Closed

Implement WebviewPanel.reveal() #4787

wants to merge 4 commits into from

Conversation

vparfonov
Copy link
Contributor

Need for #4339

@benoitf
Copy link
Contributor

benoitf commented Apr 2, 2019

@vparfonov FYI the Signed-Off is invalid (eclipsefdn/eca) check

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@akosyakov
Copy link
Member

@vparfonov How can one verify that it works? Do you have a VS Code extension?

@vparfonov
Copy link
Contributor Author

vparfonov commented Apr 3, 2019

@akosyakov
This demo from master master
This from my branchreveal

I used this sample for testing https://github.com/Microsoft/vscode-extension-samples/tree/master/webview-sample

Signed-off-by: Vitalii Parfonov <[email protected]>
@akosyakov
Copy link
Member

It does not seem to receive focus, if a widget has focus its tab should be highlighted blue. It happens automatically when any child node of a widget is document.activeElement.

@akosyakov
Copy link
Member

https://github.com/theia-ide/theia/blob/48743de06e33ea812dddc3b70b0900ea9f77c754/packages/plugin-ext/src/main/browser/webviews-main.ts#L89-L92 is bogus as well, should be aligned.

I think focus function should not be exposed out of Webview and only used in onActivateRequest.

@vparfonov
Copy link
Contributor Author

is bogus as well, should be aligned.

Yes looks like you are right, i will remove this code. Thanks

Signed-off-by: Vitalii Parfonov <[email protected]>
@akosyakov
Copy link
Member

I've modified the sample example with input field and it does not work. I will open an alternative PR to solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants