-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement WebviewPanel.reveal() #4787
Conversation
Signed-off-by: Vitalii Parfonov <[email protected]>
Signed-off-by: Vitalii Parfonov <[email protected]>
@vparfonov FYI the Signed-Off is invalid (eclipsefdn/eca) check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@vparfonov How can one verify that it works? Do you have a VS Code extension? |
@akosyakov I used this sample for testing https://github.com/Microsoft/vscode-extension-samples/tree/master/webview-sample |
Signed-off-by: Vitalii Parfonov <[email protected]>
It does not seem to receive focus, if a widget has focus its tab should be highlighted blue. It happens automatically when any child node of a widget is |
https://github.com/theia-ide/theia/blob/48743de06e33ea812dddc3b70b0900ea9f77c754/packages/plugin-ext/src/main/browser/webviews-main.ts#L89-L92 is bogus as well, should be aligned. I think |
Yes looks like you are right, i will remove this code. Thanks |
Signed-off-by: Vitalii Parfonov <[email protected]>
I've modified the sample example with input field and it does not work. I will open an alternative PR to solve it. |
Need for #4339