Implement plugin API to get workspace folder by file URI #3718
Conversation
| @@ -63,13 +63,13 @@ export class WorkspaceMainImpl implements WorkspaceMain { | |||
|
|
|||
| notifyWorkspaceFoldersChanged(): void { | |||
| if (this.roots && this.roots.length) { | |||
There was a problem hiding this comment.
not part of your change - this.roots won't be null or undefined, and therefore checking it is not necessary :)
There was a problem hiding this comment.
@elaihau Thanks for the review,
I'm going to open another PR where this checking is removed.
| return uri; | ||
| } | ||
|
|
||
| if (this.matchPaths(resourcePath, folderPath) && (!workspaceFolder || folderPath.length > workspaceFolder.uri.toString().length)) { |
There was a problem hiding this comment.
You may go with something like this:
if (folderPath.startsWith(resourcePath) && (!workspaceFolder || folderPath.length > workspaceFolder.uri.toString().length)) {There was a problem hiding this comment.
@mmorhun thanks for review
startsWith doesn't fit here, because in this case file /home/user/project_2/src/main.js matches the workspace folder /home/user/project, which is not correct.
There was a problem hiding this comment.
Well, you may ensure the trailing slash for resourcePath.
But up to you, I do not force)
| const resourcePathCrumbs = resourcePath.split('/'); | ||
| const folderPathCrumbs = folderPath.split('/'); | ||
|
|
||
| for (let i = 0; i < folderPathCrumbs.length; i++) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
@benoitf thanks!
updating PR
Signed-off-by: Oleksii Kurinnyi <[email protected]>
akurinnoy
force-pushed
the
get-workspace-folder
branch
from
9772557 to
f370b26
Compare
fix #3647
Signed-off-by: Oleksii Kurinnyi [email protected]