fix: warn user before starting the same debug session multiple times #14862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a debug session is initiated by the user, and the `suppressMultipleSessionWarning` is not set to `false` in the launch config, prompt the user before starting a new debug session with the same label. - Introduce `suppressMultipleSessionWarning` prop to the debug config. - Add `startedByUser` prop to the session options. Closes eclipse-theia#7917
kittaakos
changed the title
kittaakos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
When a debug session is initiated by the user, and the
suppressMultipleSessionWarningis not set totruein the launch config, prompt the user before starting a new debug session with the same label.suppressMultipleSessionWarningprop to the debug config.startedByUserprop to the session options.getLabeltoDebugSessionCloses #7917
How to test
Try to start the "same" debug config twice; Theia will warn you unless the
suppressMultipleSessionWarningis explicitly set totrue.Screen.Recording.2025-02-06.at.16.09.30.mov
Screen.Recording.2025-02-06.at.16.09.57.mov
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers