Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline the agent code #14859

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eneufeld
Copy link
Contributor

@eneufeld eneufeld commented Feb 6, 2025

What it does

Update agent code. Agents don't have a constructor anymore. All properties can be overridden directly. The ChatAgent interface is implemented by the AbstractChatAgent.

Fix #14818

How to test

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@eneufeld eneufeld force-pushed the fix/update-agent-code branch 2 times, most recently from 8ed8908 to 7270813 Compare February 6, 2025 12:02
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good! Can you rebase on latest master?

CHANGELOG.md Outdated
Comment on lines 7 to 13
## 1.59.0

<a name="breaking_changes_1.59.0">[Breaking Changes:](#breaking_changes_1.59.0)</a>

- [ai] removed constructor from AbstractChatAgent [#14859](https://github.com/eclipse-theia/theia/pull/14859)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we mention AI changes in breaking changes (yet).

@eneufeld eneufeld force-pushed the fix/update-agent-code branch from 7270813 to 6a3b5e2 Compare February 12, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting on reviewers
Development

Successfully merging this pull request may close these issues.

Rework and improve Agent and ChatModel API
2 participants