Reimplement window.menuBarVisibility preference
#10643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-grant-work
force-pushed
the
bugfix/improve-menu-handling
branch
7 times, most recently
from
f7b6756 to
c1391a0
Compare
- Uses same menu widget for compact and visible settings
- Cleans up event handling in browser and Electron
MainMenuContributions and MainMenuFactories
colin-grant-work
force-pushed
the
bugfix/improve-menu-handling
branch
from
c1391a0 to
9b41da4
Compare
1 task
|
Closing for now - seems better just to implement a focus restoration for the compact menu widget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #10571 by ensuring that the same logic is used for the main menu when
window.menuBarVisibilityiscompactas when it is not.The heart of this PR is a move to use the same menu widget for the (browser-style) main menu regardless of the value of the
window.menuBarVisibilitypreference, rather than using a context menu incompactmode. That ensures that we get the same behavior as we do with the normal menu bar, and that any fixes apply equally to both. In particular, it ensures that (1) commands invoked from the main menu do not receive ananchorargument and (2) the logic for preserving the focus context to use when a command is run is consistent between the menu bar and compact menu.While working on that, I noticed several other features of the menu implementation that could be improved:
window.menuBarVisibilitypreference handling was scattered across a number of different classes. This PR moves (almost) all references to the preference into theMainMenuContributionclasses.MainMenuFactoryandMainMenuContributionclasses. This PR moves all event handling into theMainMenuContributionclasses, with the factories only responsible for creating the widget.How to test
#10571
window.menuBarVisibilitypreference to'compact'(non-OSX only)General
window.menuBarVisibilitystates.window.titleBarStyleandwindow.menuBarVisibilitystates and transitions.Review checklist
Reminder for reviewers