Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search-in-workspace: fix padding when hovering over head node #10388

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

Archie27376
Copy link
Contributor

What it does

Fixes #10363
The pull-request fixes an issue which causes content in the search-in-workspace tree nodes to shift when hovered. The fix ensures that the shift no longer happens by update the flex property for the button container.

How to test

  • start the application, and open the search-in-workspace view
  • perform a search which yields results
  • confirm that hovering over nodes does not cause them to move

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added search in workspace issues related to the search-in-workspace ui/ux issues related to user interface / user experience labels Nov 5, 2021
@vince-fugnitto vince-fugnitto requested a review from msujew November 5, 2021 14:10
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the behavior works as intended, and resolves the bug on master:

  • no more shifting for standard search results
  • styling looks correct when resized, when the replace icon is present
  • styling looks correct when a single or multi-root workspace are used

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes also look good to me, and I couldn't notice any regressions 👍

@vince-fugnitto vince-fugnitto merged commit a029a72 into eclipse-theia:master Nov 8, 2021
@vince-fugnitto vince-fugnitto deleted the Result_Padding branch November 8, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
search in workspace issues related to the search-in-workspace ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

search-in-workspace: fix tree styling which causes visual glitch
3 participants