plugin: stub setKeysForSync
#10205
Merged
plugin: stub setKeysForSync
#10205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit stubs the method `setKeysForSync` as it is currently not supported by the framework and likely uses vscode online services to store data across machines. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/stub-settingsSync
branch
from
4c2b3d9 to
54c53a9
Compare
paul-marechal
approved these changes
Sep 30, 2021
marcdumais-work
approved these changes
Sep 30, 2021
There was a problem hiding this comment.
LGTM - quickly tested and confirmed that the latest available ESLint now activate correctly. GitLens has another issue not related to this stubbed API AFAIK...
Thanks for the quick turn-around @vince-fugnitto !
The commit stubs `ExtensionMode` in order not to fail on activation of popular extensions (ex: gitlens). The proper implementation should be done in future iterations. Signed-off-by: vince-fugnitto <[email protected]>
|
@marcdumais-work I added an additional commit to stub #10201 in order for the gitlens extension (and any extension using |
marcdumais-work
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #10204.
The commit stubs the method
setKeysForSyncas it is currently not supported by the framework and likely uses vscode online services to store data across machines.How to test
eslintorgitlensthrough the extensions-viewsetKeysForSyncReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]