file-dialog: apply the default filter #10133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-grant-work
approved these changes
Sep 17, 2021
vince-fugnitto
force-pushed
the
vf/file-dialog-filter
branch
from
a5b7398 to
cf7434c
Compare
The commit fixes an issue where the `file-dialog` filter was not respected when we display the dialog initially. Previously a change event in the filter meant that the dialog was properly filtered. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/file-dialog-filter
branch
from
cf7434c to
4420340
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #10132
The pull-request addresses an issue where the default filter for the
file-dialogis not being applied when the dialog is first displayed. The change addresses this issue and applies the filter properly initially.How to test
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]