cli: support downloading .theia plugins
#10082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit updates the `download-plugins` script to allow the downloading of `.theia` (theia-plugins). Previously, the download would fail if an application references a `.theia` file as it was an unsupported file extension. Signed-off-by: vince-fugnitto <[email protected]>
paul-marechal
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #9264.
The pull-request updates the
download-pluginsscript to allow the downloading of.theiafiles (theia-plugins).Previously, the operation would fail as it was treated as an unsupported file type.
How to test
theiaPlugins:yarn download:pluginsplugins/foldertheia: hello worldand confirm it is successulReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]