Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot create a new file if the preferences widget is opened. #7067

Closed
kittaakos opened this issue Feb 4, 2020 · 0 comments · Fixed by #7302
Closed

Cannot create a new file if the preferences widget is opened. #7067

kittaakos opened this issue Feb 4, 2020 · 0 comments · Fixed by #7302
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help preferences issues related to preferences

Comments

@kittaakos
Copy link
Contributor

Description

File: New File (command or keybinding) has no effect if the preferences widget is opened.

Reproduction Steps

  • Open an empty workspace,
  • Open the preferences widget,
  • Execute the File: New File from the command palette, or with Ctrl/Cmd+N.
  • Nothing happens, no erros either.

It is just a guess, but we do not fall back to the workspace root URI, as the parent of the new file, but get the URI from the preferences editor which is user_storage:settings.json.

If I close the preferences widget, it works.

OS and Theia version:

Diagnostics:
@kittaakos kittaakos added the bug bugs found in the application label Feb 4, 2020
@kittaakos kittaakos mentioned this issue Feb 4, 2020
Closed
@vince-fugnitto vince-fugnitto added the preferences issues related to preferences label Feb 4, 2020
@vince-fugnitto vince-fugnitto mentioned this issue Mar 2, 2020
Closed
@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Mar 3, 2020
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Mar 9, 2020
Cannot create a new file if the preferences widget is opened.
6b8ded1 
Fixes: eclipse-theia#7067 , eclipse-theia#7253

Initially we were unable to create a new file or folder while the user preferences was open.

The user-preferences has the file scheme set as `user-storage` and we did not fall back to the workspace root URI and instead were getting the URI from 'user_storage:settings.json'.
With this approach, we create files at certain directories and if a directory doesn't have the scheme set to 'file' it will fallback to the workspace root uri.

Signed-off-by: Muhammad Anas Shahid <[email protected]>
@Anasshahidd21 Anasshahidd21 mentioned this issue Mar 9, 2020
Merged
1 task
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Mar 10, 2020
Cannot create a new file if the preferences widget is opened.
f432355 
Fixes: eclipse-theia#7067 , eclipse-theia#7253

Initially we were unable to create a new file or folder while the user preferences was open.

The user-preferences has the file scheme set as `user-storage` and we did not fall back to the workspace root URI and instead were getting the URI from 'user_storage:settings.json'.
With this approach, we create files at certain directories and if a directory doesn't have the scheme set to 'file' it will fallback to the workspace root uri.

Signed-off-by: Muhammad Anas Shahid <[email protected]>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Mar 10, 2020
Cannot create a new file if the preferences widget is opened.
ab3b9b8 
Fixes: eclipse-theia#7067 , eclipse-theia#7253

Initially we were unable to create a new file or folder while the user preferences was open.

The user-preferences has the file scheme set as `user-storage` and we did not fall back to the workspace root URI and instead were getting the URI from 'user_storage:settings.json'.
With this approach, we create files at certain directories and if a directory doesn't have the scheme set to 'file' it will fallback to the workspace root uri.

Signed-off-by: Muhammad Anas Shahid <[email protected]>
lmcbout pushed a commit that referenced this issue Mar 25, 2020
@lmcbout
Cannot create a new file if the preferences widget is opened.
01394fb 
Fixes: #7067 , #7253

Initially we were unable to create a new file or folder while the user preferences was open.

The user-preferences has the file scheme set as `user-storage` and we did not fall back to the workspace root URI and instead were getting the URI from 'user_storage:settings.json'.
With this approach, we create files at certain directories and if a directory doesn't have the scheme set to 'file' it will fallback to the workspace root uri.

Signed-off-by: Muhammad Anas Shahid <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help preferences issues related to preferences
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix creating a new file or folder if the preferences widget is opened. Anasshahidd21/theia
3 participants
@kittaakos @akosyakov @vince-fugnitto