Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[monaco] New keybinding collision because of the context #1888

Closed
paul-marechal opened this issue May 11, 2018 · 2 comments
Closed

[monaco] New keybinding collision because of the context #1888

paul-marechal opened this issue May 11, 2018 · 2 comments
Assignees
Labels
keybindings issues related to keybindings monaco issues related to monaco

Comments

@paul-marechal
Copy link
Member

paul-marechal commented May 11, 2018

Monaco seems to have added new keybindings that we load in Theia, but they use different contexts to avoid collisions, while we do not: our default context for any monaco's binding is editorTextFocus.

[2018-05-11T12:58:34.238Z]  WARN: Theia/9773 on elxa8wlvvz1: (logger=root)
    Collided keybinding is ignored;  [ '{"command":"monaco.editor.action.wordHighlight.next","keybinding":"f7","context":"editorTextFocus"}',
      ' collided with ',
      '{"command":"monaco.editor.action.diffReview.next","keybinding":"f7","context":"editorTextFocus"}' ]

[2018-05-11T12:58:34.240Z]  WARN: Theia/9773 on elxa8wlvvz1: (logger=root)
    Collided keybinding is ignored;  [ '{"command":"monaco.editor.action.wordHighlight.prev","keybinding":"shift+f7","context":"editorTextFocus"}',
      ' collided with ',
      '{"command":"monaco.editor.action.diffReview.prev","keybinding":"shift+f7","context":"editorTextFocus"}' ]

Monaco's context for each (command / keybinding / context):

  • monaco.editor.action.diffReview.next / f7 / isInDiffEditor
  • monaco.editor.action.wordHighlight.next / f7 / editorTextFocus && hasWordHighlights
  • monaco.editor.action.diffReview.prev / shift+f7 / isInDiffEditor
  • monaco.editor.action.wordHighlight.prev / shift+f7 / editorTextFocus && hasWordHighlights
@paul-marechal paul-marechal changed the title [monaco] New keybinding collision based on the context [monaco] New keybinding collision because of the context May 11, 2018
@paul-marechal paul-marechal added keybindings issues related to keybindings monaco issues related to monaco labels May 11, 2018
@MarkZ3
Copy link
Contributor

MarkZ3 commented Jul 11, 2018

Please note that for Electron, you have to use a different command now to see the logging, see #2344

@paul-marechal
Copy link
Member Author

@vince-fugnitto cc

AlexTugarev added a commit that referenced this issue Dec 5, 2018
AlexTugarev added a commit that referenced this issue Dec 5, 2018
bogthe pushed a commit to ARMmbed/theia that referenced this issue Jan 21, 2019
Fixes eclipse-theia#1888

Signed-off-by: Alex Tugarev <[email protected]>
Signed-off-by: Bogdan Stolojan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keybindings issues related to keybindings monaco issues related to monaco
Projects
None yet
Development

No branches or pull requests

3 participants