-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[monaco] New keybinding collision because of the context #1888
Labels
Comments
paul-marechal
changed the title
[monaco] New keybinding collision based on the context
[monaco] New keybinding collision because of the context
May 11, 2018
paul-marechal
added
keybindings
issues related to keybindings
monaco
issues related to monaco
labels
May 11, 2018
Please note that for Electron, you have to use a different command now to see the logging, see #2344 |
AlexTugarev
added a commit
that referenced
this issue
Oct 16, 2018
Fixes #1888 Signed-off-by: Alex Tugarev <[email protected]>
AlexTugarev
added a commit
that referenced
this issue
Dec 5, 2018
Fixes #1888 Signed-off-by: Alex Tugarev <[email protected]>
AlexTugarev
added a commit
that referenced
this issue
Dec 5, 2018
Fixes #1888 Signed-off-by: Alex Tugarev <[email protected]>
bogthe
pushed a commit
to ARMmbed/theia
that referenced
this issue
Jan 21, 2019
Fixes eclipse-theia#1888 Signed-off-by: Alex Tugarev <[email protected]> Signed-off-by: Bogdan Stolojan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Monaco seems to have added new keybindings that we load in Theia, but they use different contexts to avoid collisions, while we do not: our default context for any monaco's binding is
editorTextFocus
.Monaco's context for each (
command / keybinding / context
):monaco.editor.action.diffReview.next / f7 / isInDiffEditor
monaco.editor.action.wordHighlight.next / f7 / editorTextFocus && hasWordHighlights
monaco.editor.action.diffReview.prev / shift+f7 / isInDiffEditor
monaco.editor.action.wordHighlight.prev / shift+f7 / editorTextFocus && hasWordHighlights
The text was updated successfully, but these errors were encountered: