Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] Definition of LocationLink and DefinitionLink is reversed compared to VSCode #11464

Closed
planger opened this issue Jul 26, 2022 · 1 comment · Fixed by #11465
Closed
Labels
vscode issues related to VSCode compatibility

Comments

@planger
Copy link
Contributor

planger commented Jul 26, 2022

Bug Description:

See definition of LocationLink in Theia:

export type LocationLink = DefinitionLink;

export interface DefinitionLink {

And how it is defined in VS Code:
https://github.com/microsoft/vscode/blob/e4ed3e085524e3947308126fab86cb6ebee85675/src/vscode-dts/vscode.d.ts#L2637

While the definition is semantically correct, it still causes the report generated by the vscode-theia-comparator to list LocationLink as missing. So I suggest to change the definition so it is consistent with VSCode and also makes the report happy. :-)

Steps to Reproduce:

  1. Open the report
  2. See how it reports the properties of LocationLink as missing
planger added a commit to eclipsesource/theia that referenced this issue Jul 26, 2022
Fixes eclipse-theia#11464

Contributed on behalf of STMicroelectronics.

Change-Id: Ibf63bd38a2d7b0754355edcdf2002aba60a0ffe5
Signed-off-by: Philip Langer <[email protected]>
@planger
Copy link
Contributor Author

planger commented Jul 26, 2022

See also #10024 and #10139

@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Jul 26, 2022
JonasHelming pushed a commit that referenced this issue Jul 27, 2022
Fixes #11464

Contributed on behalf of STMicroelectronics.

Change-Id: Ibf63bd38a2d7b0754355edcdf2002aba60a0ffe5
Signed-off-by: Philip Langer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants