Mark only those commands ran using quick menu as recent

Signed-off-by: Dmitry Sharshakov <[email protected]>
eclipse-theia · Apr 12, 2020 · 82555f6 · 82555f6
1 parent cb3db2a
commit 82555f6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/core/src/browser/quick-open/quick-command-service.ts b/packages/core/src/browser/quick-open/quick-command-service.ts
@@ -248,6 +248,10 @@ export class CommandQuickOpenItem extends QuickOpenGroupItem {
             // reset focus on the previously active element.
             this.activeElement.focus({ preventScroll: true });
             this.commands.executeCommand(this.command.id);
+
+            if (this.command) {
+                this.commands.addRecentCommand(this.command);
+            }
         }, 50);
         return true;
     }

diff --git a/packages/core/src/common/command.ts b/packages/core/src/common/command.ts
@@ -289,10 +289,6 @@ export class CommandRegistry implements CommandService {
             await this.fireWillExecuteCommand(commandId, args);
             const result = await handler.execute(...args);
             this.onDidExecuteCommandEmitter.fire({ commandId, args });
-            const command = this.getCommand(commandId);
-            if (command) {
-                this.addRecentCommand(command);
-            }
             return result;
         }
         const argsMessage = args && args.length > 0 ? ` (args: ${JSON.stringify(args)})` : '';