no atomic writeJSON with a temporary file and atomic rename to desire…

…d file Signed-off-by: Dmitry Maslennikov <[email protected]>
eclipse-theia · Aug 26, 2020 · 74e6495 · 74e6495
1 parent b0f1fe7
commit 74e6495
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/packages/plugin-ext/src/main/node/plugins-key-value-storage.ts b/packages/plugin-ext/src/main/node/plugins-key-value-storage.ts
@@ -101,7 +101,7 @@ export class PluginsKeyValueStorage {
             return {};
         }
         try {
-            return fs.readJSONSync(pathToFile);
+            return await fs.readJSON(pathToFile);
         } catch (error) {
             console.error('Failed to parse data from "', pathToFile, '". Reason:', error);
             return {};
@@ -110,7 +110,16 @@ export class PluginsKeyValueStorage {
 
     private async writeToFile(pathToFile: string, data: KeysToKeysToAnyValue): Promise<void> {
         await fs.ensureDir(path.dirname(pathToFile));
-        fs.writeJSONSync(pathToFile, data);
+        const tmpFile = pathToFile + '.tmp';
+        await new Promise((resolve, reject) => {
+            fs.writeJSON(tmpFile, data, {}, error => {
+                if (error) {
+                    reject(error);
+                } else {
+                    fs.rename(tmpFile, pathToFile, resolve);
+                }
+            });
+        });
     }
 
 }