Split Theia IDE and platform website #659
Conversation
JonasHelming
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
|
|
This looks great, I think it's much clearer than the current page. |
|
@JonasHelming the new site has a bunch of links to https://eclipse-theia.github.io/, which is a 404. Is that expected? |
Example please? I believe these are the typeDoc links, see: #651 |
|
When I click on the prominent "Explore the Theia Platform" button |
Signed-off-by: Jonas Helming <[email protected]>
This was, because it opened in new window, I fixed this. Please note that the preview is hosted on github.io, but links should still work. If they don't there is something wrong, so please give me all examples. |
JonasHelming
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
|
@JonasHelming in the latest deployment https://eclipse-theia.github.io/theia-website-previews/pr-previews/pr-659/ the link still does not work (404) |
JonasHelming
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
Signed-off-by: Jonas Helming <[email protected]>
JonasHelming
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
Sorry, please check again and please let me know the other examples |
| @@ -104,7 +104,8 @@ const TheiaIDEDownloads = () => ( | |||
| Help us make the Theia IDE even better, by <a href="https://github.com/eclipse-theia/theia/discussions">sharing your experience and suggestions</a>. | |||
| The features found in the Eclipse Theia IDE are based on Eclipse Theia and the available extensions/plugins. For more details please see the <a href="https://github.com/eclipse-theia/theia">Eclipse Theia GitHub Repository</a>. The Eclipse Theia IDE only packages existing Eclipse Theia functionality and installers. If you believe there is a mistake in packaging, something needs to be added to the packaging or the installers do not work properly, please <a href="https://github.com/eclipse-theia/theia-blueprint/issues/new/choose">open an issue on GitHub</a> to let us know. | |||
| <h1>Support</h1> | |||
| Need help with Theia? To get support by the community go to the <a href="https://github.com/eclipse-theia/theia/discussions">Discussions at GitHub</a>. To get professional support for Theia see the <a href="./support/">support page</a>. | |||
| Please refer to the <a href="/docs/user_getting_started/">Theia IDE Documentation</a>. | |||
| <Footer background={true} /> | ||
| </Layout> | ||
| ) | ||
| } |
There was a problem hiding this comment.
Is your IDE set to remove trailing newlines?
There was a problem hiding this comment.
Do you mean the one after {true} ?
There was a problem hiding this comment.
No, I mean at the end of the file. It looks like the PR is removing them.
Signed-off-by: Jonas Helming <[email protected]>
JonasHelming
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
| <Footer background={true} /> | ||
| </Layout> | ||
| ) | ||
| } |
There was a problem hiding this comment.
No, I mean at the end of the file. It looks like the PR is removing them.
Signed-off-by: Jonas Helming <[email protected]>
This is unrelated to the split I think, I created a new issue. |
|
@msujew Are you fine with the split? |
|
@JonasHelming The current home page renders just fine on mobile devices. It's the split that's introducing the issue:
|
|
AFAICS, you are looking at two different parts of the home page: The adopter section for the platform which is responsive and the one under theia IDE, which is not. And this applies for me on both versions. |
fixed #658
This PR is focussed on the Split only, it does not contain any further optimizations (which are now easier).
I am happy for any feedback, if possible in two categories: