-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tooling: Correct upper case values in docs build errors. #426
tooling: Correct upper case values in docs build errors. #426
Conversation
The created documentation from the pull request is available at: docu-html |
With the regexes you just proposed we loose the information where we need to set the first two underscores. It´s not clear for me how you want to check this later. My proposal would be:
|
The underscores are not touched. Why do we need to know where they are? |
Just updated the regex with this we would fix the prefixes |
d240bc1
to
9ff82ee
Compare
@hoe-jo I manually reviewed every value I changed and didn't find any lost information. The 2 regex worked well and made the objective of PR. If you found any example of lost infos in this PR please mention it so that I can see how to correct it. |
Ok, let me please reformulate then: Currently we can distinguish between prefix and keyword: If we change it to: How do we (later) introduce here the 2nd underscore? We already lost here the information what is prefix and what is keyword, other example: To add here the 2nd (missing) underscore we would have to search for each workproduct itself later and correct it With the Regex: This is done automatically in one step |
9ff82ee
to
d4a4471
Compare
@hoe-jo the underscore handling will be in the next PR |
Fine for me if you know how to separate those later |
We should use different need types for differentiation and not id-naming-rules. |
Mhh this PR does not actually reduce the number of warnings?! |
@AlexanderLanin We need to complete the underscore part to reduce the build errors as most of needs are not following the patters and not only are in big letters |
But this PR does not reduce warnings. It's still ~1500 warnings, same as before. |
@AlexanderLanin Yes after doing my changes and before merging the main and resolving the conflicts somehow the errors where 1078 then they become >1800 after the merge and squash of the main I still don't get it as I resolve some small conflicts in 4 or 5 files which contains some valid ids and options but most of errors are related to underscore |
Replace all ids and options items by their value in small letters. Also-by: Aymen Soussi [email protected]
d4a4471
to
9c70b51
Compare
@AlexanderLanin I just corrected one of the checks (check_id_format) and the errors now have been reduced to 1651 error |
Replace all ids and options items by their value in small letters.
Also-by: Aymen Soussi [email protected]
I used 2 regex to do the job (:[a-z]: .__.) and (:[a-z]: ._.) and replaced them with \L$1 all using VS Code option to search and replace regex patterns to handle all options and id cases that not follow the pattern.
In another PR we will handle the case of id and options that start only with one "_" Plus there were some small mistakes like changing ASIL_D/B to asil_d/b and some small unnecessary ones that I fixed manually by returning them to their old value.
After the correction of the check_id_format we reduced more then 200 build errors
Related to: #282