Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WARNING: dangerous @SuppressWarnings("removal") added #385

Open
jukzi opened this issue Mar 29, 2023 · 3 comments
Open

WARNING: dangerous @SuppressWarnings("removal") added #385

jukzi opened this issue Mar 29, 2023 · 3 comments

Comments

@jukzi
Copy link
Contributor

jukzi commented Mar 29, 2023

see #356 (comment)

Eclipse IDE needs to get rid of code to be removed or changed in future JDK. Even if not removed but becoming a NO-OP in future JDKs there could be serious issues with future JDKs when code does not do anymore what it used to do.
@jukzi
Copy link
Contributor Author

jukzi commented Mar 30, 2023

Please also note, that already JDK 17 loggs warnings to ERR like (when for example running org.eclipse.ant.tests.ui.BuildTests.testVerboseStackTrace()):

WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.eclipse.ant.internal.core.ant.InternalAntRunner (file:C:/Users/jkubitz/platform-2023-03-16/git/eclipse.platform/ant/org.eclipse.ant.core/lib/antsupportlib.jar)
WARNING: Please consider reporting this to the maintainers of org.eclipse.ant.internal.core.ant.InternalAntRunner
WARNING: System::setSecurityManager will be removed in a future release

@iloveeclipse
Copy link
Member

iloveeclipse commented Mar 31, 2023 •
edited
Loading

Deprecation warnings we see in JDK 17 on API that is marked for removal (probably with JDK 21 - next LTS) :

  • java.security.AccessController
  • java.lang.SecurityManager
  • java.lang.System.getSecurityManager()

We should address that.

akurtakov added a commit to akurtakov/p2 that referenced this issue Apr 3, 2023
@akurtakov
Silence warnings in CoercingComparator
c4c3af7 
Rawtypes one was removed by error while moving to Java 17 and
AccessController.doPrivileged has no clear replacement and stays until
JVM actually removes this one.
eclipse-platform/eclipse.platform#385 is the
general tracking issue for SecurityManager removal in the JVM
akurtakov added a commit to akurtakov/p2 that referenced this issue Apr 3, 2023
@akurtakov
Silence warnings in CoercingComparator
496e304 
Rawtypes one was removed by error while moving to Java 17 and
AccessController.doPrivileged has no clear replacement and stays until
JVM actually removes this one.
eclipse-platform/eclipse.platform#385 is the
general tracking issue for SecurityManager removal in the JVM
@akurtakov akurtakov mentioned this issue Apr 3, 2023
Merged
akurtakov added a commit to eclipse-equinox/p2 that referenced this issue Apr 3, 2023
@akurtakov
Silence warnings in CoercingComparator
6bfbb34 
Rawtypes one was removed by error while moving to Java 17 and
AccessController.doPrivileged has no clear replacement and stays until
JVM actually removes this one.
eclipse-platform/eclipse.platform#385 is the
general tracking issue for SecurityManager removal in the JVM
@jukzi
Copy link
Contributor Author

jukzi commented Apr 18, 2023

It's not fun to work with a current OOmphed Platform workspace with JDK 19 (eclipse-platform/.github#114) as there are repeadadly exceptions logged: 'Setting Security Manager is not supported'

An exception stack trace is not available.
eclipse.buildId=4.28.0.I20230417-1800
java.version=19.0.2
java.vendor=Eclipse Adoptium
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=de_DE
Command-line arguments:  -os win32 -ws win32 -arch x86_64 -data C:\Users\JKubitz\eclipseDev\platform-sdk20230418\Latest

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iloveeclipse @jukzi