Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[win32] strict check to identify long running GC #1803

Conversation

akoch-yatta
Copy link
Contributor

This commit adds a check to identify long running or misconfigured GCs that render in a different zoom as its creating drawable intended to. Only executes if strict checking is enabled.

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Test Results

   494 files  ±0     494 suites  ±0   8m 41s ⏱️ -48s
 4 333 tests ±0   4 319 ✅ ±0   14 💤 ±0  0 ❌ ±0 
16 574 runs  ±0  16 465 ✅ ±0  109 💤 ±0  0 ❌ ±0 

Results for commit b9e48d8. ± Comparison against base commit 9d3673c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Just some proposal for improving the message.

@akoch-yatta akoch-yatta force-pushed the win32-detect-invalid-longrunning-gc branch from 031ee57 to 3bf7cde Compare February 5, 2025 08:26
This commit adds a check to identify long running or misconfigured GCs
that render in a different zoom as its creating drawable intended to.
Only executes if strict checking is enabled.
@HeikoKlare HeikoKlare force-pushed the win32-detect-invalid-longrunning-gc branch from 3bf7cde to b9e48d8 Compare February 5, 2025 10:52
@HeikoKlare HeikoKlare merged commit 81ac825 into eclipse-platform:master Feb 5, 2025
14 checks passed
@HeikoKlare HeikoKlare deleted the win32-detect-invalid-longrunning-gc branch February 5, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identification of Long-Living (Potential Not-DPI-Updated) GCs
2 participants