Calculate Scaling for Font without Device#getDPI() #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShahzaibIbrahim
force-pushed
the
master-210
branch
from
79d387b to
79f50d5
Compare
This was
linked to
issues
Feb 5, 2025
akoch-yatta
force-pushed
the
master-210
branch
3 times, most recently
from
c7f8c08 to
e789f41
Compare
akoch-yatta
reviewed
Feb 5, 2025
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Device.java
Show resolved
Hide resolved
fedejeanne
reviewed
Feb 5, 2025
There was a problem hiding this comment.
FWIW I tested this in Mac and it doesn't produce any regressions. See vi-eclipse/Eclipse-Platform#159 (comment)
This commit solves two interconneted issues. Wrong layouting when text is printed and wrongly scaled fonts for printing. Device#getDPI returns values for Display and Printer that lead to wrong assumption using getDPI e.g. in the ScalingSWTFontRegistry. Printing text is broken because Printer DPI (e.g. 600) is way different from the Monitor DPI (96) that lead to inconsistent Font behavior in the different scenarios. Now font scaling is utilizing the zoom level instead of DPI in relavant scenarios.
akoch-yatta
force-pushed
the
master-210
branch
from
e789f41 to
fbc1b3a
Compare
akoch-yatta
reviewed
Feb 6, 2025
...les/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/StyledText.java
Show resolved
Hide resolved
fedejeanne
reviewed
Feb 10, 2025
|
FTR I'm talking about testing the very last change (https://github.com/eclipse-platform/eclipse.platform.swt/compare/e789f41c2192b54821d6315a47324aab475b0683..fbc1b3a140d1f78049f6b18c39a3ce0e32c2553a) on Mac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getDPI always returns points for primary monitor and can produce faulty behavior. Printing the code is broken because Printer DPI (400) is different from the Monitor DPI (100). Now we compute points from the zoom level instead of currentFontDPI.
How to Test
Before Fix
After Fix