Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jdk24 OpenJDK java/util/zip/DeflateIn_InflateOut fails in SkipBytes on zlinux #21054

Open
pshipton opened this issue Feb 1, 2025 · 11 comments
Open

Comments

@pshipton
Copy link
Member

pshipton commented Feb 1, 2025

https://openj9-jenkins.osuosl.org/job/Test_openjdk24_j9_sanity.openjdk_s390x_linux_Nightly_testList_2/6 - rh8-390-1
jdk_util_1
java/util/zip/DeflateIn_InflateOut.java

03:24:13  java.lang.Exception: Stack trace
03:24:13  	at java.base/java.lang.Thread.dumpStack(Thread.java:2026)
03:24:13  	at DeflateIn_InflateOut.fail(DeflateIn_InflateOut.java:298)
03:24:13  	at DeflateIn_InflateOut.fail(DeflateIn_InflateOut.java:292)
03:24:13  	at DeflateIn_InflateOut.check(DeflateIn_InflateOut.java:301)
03:24:13  	at DeflateIn_InflateOut.SkipBytes(DeflateIn_InflateOut.java:192)
03:24:13  	at DeflateIn_InflateOut.realMain(DeflateIn_InflateOut.java:284)
03:24:13  	at DeflateIn_InflateOut.main(DeflateIn_InflateOut.java:307)

https://openj9-jenkins.osuosl.org/job/Test_openjdk24_j9_sanity.openjdk_s390x_linux_Nightly_testList_1/7/ - rh8-390-1
jdk_util_0
java/util/zip/DeflateIn_InflateOut.java

03:34:29  java.lang.Exception: Stack trace
03:34:29  	at java.base/java.lang.Thread.dumpStack(Thread.java:2026)
03:34:29  	at DeflateIn_InflateOut.fail(DeflateIn_InflateOut.java:298)
03:34:29  	at DeflateIn_InflateOut.fail(DeflateIn_InflateOut.java:292)
03:34:29  	at DeflateIn_InflateOut.check(DeflateIn_InflateOut.java:301)
03:34:29  	at DeflateIn_InflateOut.SkipBytes(DeflateIn_InflateOut.java:192)
03:34:29  	at DeflateIn_InflateOut.realMain(DeflateIn_InflateOut.java:284)
03:34:29  	at DeflateIn_InflateOut.main(DeflateIn_InflateOut.java:307)
03:34:29  	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
03:34:29  	at java.base/java.lang.reflect.Method.invoke(Method.java:571)
03:34:29  	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:333)
03:34:29  	at java.base/java.lang.Thread.run(Thread.java:1458)
03:34:29  java.lang.Exception: Stack trace
03:34:29  	at java.base/java.lang.Thread.dumpStack(Thread.java:2026)
03:34:29  	at DeflateIn_InflateOut.fail(DeflateIn_InflateOut.java:298)
03:34:29  	at DeflateIn_InflateOut.fail(DeflateIn_InflateOut.java:292)
03:34:29  	at DeflateIn_InflateOut.check(DeflateIn_InflateOut.java:301)
03:34:29  	at DeflateIn_InflateOut.SkipBytes(DeflateIn_InflateOut.java:210)
03:34:29  	at DeflateIn_InflateOut.realMain(DeflateIn_InflateOut.java:284)
03:34:29  	at DeflateIn_InflateOut.main(DeflateIn_InflateOut.java:307)
03:34:29  	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
03:34:29  	at java.base/java.lang.reflect.Method.invoke(Method.java:571)
03:34:29  	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:333)
03:34:29  	at java.base/java.lang.Thread.run(Thread.java:1458)
03:34:29  java.lang.Exception: Stack trace
03:34:29  	at java.base/java.lang.Thread.dumpStack(Thread.java:2026)
03:34:29  	at DeflateIn_InflateOut.fail(DeflateIn_InflateOut.java:298)
03:34:29  	at DeflateIn_InflateOut.fail(DeflateIn_InflateOut.java:292)
03:34:29  	at DeflateIn_InflateOut.check(DeflateIn_InflateOut.java:301)
03:34:29  	at DeflateIn_InflateOut.SkipBytes(DeflateIn_InflateOut.java:219)
03:34:29  	at DeflateIn_InflateOut.realMain(DeflateIn_InflateOut.java:284)
03:34:29  	at DeflateIn_InflateOut.main(DeflateIn_InflateOut.java:307)

Maybe unrelated, but changes from previous build:
64284dd...82081e2
eclipse-openj9/openj9-omr@c8aae7c...507377a

@pshipton pshipton added this to the Java 24 (0.50) milestone Feb 1, 2025
@pshipton pshipton added the jdk24 label Feb 1, 2025
@pshipton pshipton changed the title OpenJDK java/util/zip/DeflateIn_InflateOut fails in SkipBytes on zlinux jdk24 OpenJDK java/util/zip/DeflateIn_InflateOut fails in SkipBytes on zlinux Feb 1, 2025
@pshipton
Copy link
Member Author

pshipton commented Feb 1, 2025

@r30shah @hzongaro fyi

@pshipton
Copy link
Member Author

pshipton commented Feb 1, 2025

Maybe a machine specific failure?
FYI the test is excluded jdk8 - jdk17 due to #14948

@pshipton pshipton removed the blocker label Feb 1, 2025
@hzongaro
Copy link
Member

hzongaro commented Feb 7, 2025

It looks like this was seen recently with JDK 21 zLinux, as mentioned in #20696 (comment). I cannot tell from that which machine might have encountered the problem.

@r30shah
Copy link
Contributor

r30shah commented Feb 7, 2025

Both failures are on Red hat 8 on z15 which would have NXU compression enabled. This is the same issue as #14948

@pshipton
Copy link
Member Author

pshipton commented Feb 7, 2025

@r30shah That was my original thought, but these failures are different so I wasn't sure.

@r30shah
Copy link
Contributor

r30shah commented Feb 7, 2025

The stacktrace looked same to the failure described in #14948 (comment) (Which was failing in DeflateIn_InflateOut.SkipBytes), so I do suspect, that it is highly likely to be same issue. But will check it again with JDK21 on the machine, and will post update here.

@r30shah r30shah self-assigned this Feb 7, 2025
@vij-singh
Copy link

Any new news?

@r30shah
Copy link
Contributor

r30shah commented Feb 13, 2025

I looked into the test, for the original issue I pointed out in #14948 (comment), we did backport the fixes on all our extension repos and JDK24 does contain the fix, but this test fails due to hardware compression. I am able to reproduce this on our system and with DFLTCC set to 0, test passes 100/100 (Original failure is 1/10).
I will add more debug data to the locally reproducible test and get idea why it is failing. Although test was seen failing on other JDK as well on zlinux after the fix to the original issue was delivered and on other JDK, this test is disabled (#14948 (comment)). So I do not expect this to block JDK24. But given that it has resurfaced and most of the distros would have hardware compression through zlib enabled by default, will prioritize working on this.

@r30shah
Copy link
Contributor

r30shah commented Feb 26, 2025

Here is the summary of investigation,
Test skips arbitrary number of compressed bytes of data and corresponding uncompressed data from the input stream [1]. It then compresses the rest of the data and compares the sum of skipped bytes and the size of compressed data of remaining stream with the compressed data size if the whole stream was compressed without skipping [2]. It seems like test is intermittently failing (1/5 times) on the RHEL 9 system (z16) I am using which has NXU compression enabled.

I think this was the same issue last popped up in #14948 (comment) with other JDK versions, after which we disabled these test on zlinux (adoptium/aqa-tests#5902). I am going to continue investigating this but, this shouldn't be blocker or must fix for JDK24 as we already have disabled the test from older jdk versions and with that reasoning, we can disable this test on JDK24 as well.

[1]. https://github.com/ibmruntimes/openj9-openjdk-jdk24/blob/665f94fba1b8f621f21c1f978240a34ce6339655/test/jdk/java/util/zip/DeflateIn_InflateOut.java#L180-L192
[2]. https://github.com/ibmruntimes/openj9-openjdk-jdk24/blob/665f94fba1b8f621f21c1f978240a34ce6339655/test/jdk/java/util/zip/DeflateIn_InflateOut.java#L192

@pshipton
Copy link
Member Author

pshipton commented Feb 26, 2025

we can disable this test on JDK24 as well.

Yes that's fine. I was about to disable it but then noticed the failing stack was different from what we had recorded before.

@pshipton
Copy link
Member Author

Created adoptium/aqa-tests#5988

@pshipton pshipton removed this from the Java 24 (0.50) milestone Feb 26, 2025
llxia pushed a commit to adoptium/aqa-tests that referenced this issue Feb 27, 2025
judovana pushed a commit to judovana/aqa-tests that referenced this issue Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants