Avoid use of absolute path where BND can't handle it #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgraham
force-pushed
the
jonah/fixes_734
branch
from
9ea8773 to
7fb4339
Compare
BND when calculating the full path to savemanifest runs within the current dir being the root of the project. Making this change ($buildDir -> build) does not change the output but does make it work on Windows. Fixes #734
jonahgraham
force-pushed
the
jonah/fixes_734
branch
from
7fb4339 to
e32c63b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BND when calculating the full path to savemanifest runs within the current dir being the root of the project. Making this change (
$buildDir->build) does not change the output but does make it work on Windows.Fixes #734