Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gradle 7.5 and xtend-gradle-plugin 3.0.2 #667

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Conversation

cdietrich
Copy link
Contributor

Update to Gradle 7.5 and xtend-gradle-plugin 3.0.2
Added missing resources.prefs

@cdietrich cdietrich added this to the 0.16.0 milestone Sep 22, 2022
@cdietrich
Copy link
Contributor Author

@jonahgraham the PR build still seems to execute
createLocalMavenRepo
where is this one defined?

@cdietrich
Copy link
Contributor Author

it seems to be in the config, edited it. lets see

Added missing resources.prefs

Signed-off-by: Christian Dietrich <[email protected]>
Copy link
Contributor

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, I haven't reviewed a diff of the outputs, let me know if you need me to do that again.

PS Can you add something to the Changelog about the new gradle versions?

@cdietrich
Copy link
Contributor Author

would be nice, yes

@cdietrich cdietrich merged commit 3b83daf into main Sep 26, 2022
@cdietrich cdietrich deleted the cd_gradle751 branch September 26, 2022 08:45
@jonahgraham
Copy link
Contributor

would be nice, yes

I have just noticed you merged this. Do you still need a review, or are you satisfied with the change?

@cdietrich
Copy link
Contributor Author

I assume it works but if you still can do a diff it would be nice.

@jonahgraham
Copy link
Contributor

The diff looks basically identical to me. I think that makes sense as even though version of Gradle changed, version of Bnd stayed the same. I compared build output of build 63 vs build 64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants