Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module-info to the modules #830

Closed
Thihup opened this issue May 2, 2024 · 6 comments · Fixed by #843 or #868
Closed

Add module-info to the modules #830

Thihup opened this issue May 2, 2024 · 6 comments · Fixed by #843 or #868
Labels
enhancement help_wanted

Comments

@Thihup
Copy link
Contributor

Thihup commented May 2, 2024

Adding a module-info to the modules will make the life easier for whom wants to create a JLinked runtime including only the necessary modules. Most LSP servers are standalone programs, so it makes sense to create a LSP server using a JLinked runtime.
@nixel2007
Copy link
Contributor

Totally agree. BSL Language Server is packaged via jpackage and runtime image is quite huge.

@jonahgraham
Copy link
Contributor

I will be happy to review a PR that provides the needed info. Please tag me in such a PR.

Thihup added a commit to Thihup/lsp4j that referenced this issue Jun 10, 2024
@Thihup
eclipse-lsp4j#830 Add module-info to the modules
02d46c5
Thihup added a commit to Thihup/lsp4j that referenced this issue Jun 10, 2024
@Thihup
eclipse-lsp4j#830 Add module-info to the modules
d37f341
@jonahgraham jonahgraham linked a pull request Jun 10, 2024 that will close this issue
#830 Add module-info to the modules #843
Merged
jonahgraham pushed a commit that referenced this issue Aug 20, 2024
@Thihup
#830 Add module-info to the modules (#843)
7ce4f59
@jonahgraham jonahgraham added this to the 0.24.0 milestone Aug 20, 2024
@jonahgraham jonahgraham reopened this Nov 26, 2024
@jonahgraham
Copy link
Contributor

@Thihup this seems to have caused a significant regression. Please see #855 - I am hoping we can resolve the issue without needing to revert it. Please share your thoughts.

@cdietrich
Copy link
Contributor

maybe there is something that makes buildship configure the module thing correctly

@jonahgraham jonahgraham mentioned this issue Jan 8, 2025
Closed
35 tasks
@jonahgraham
Copy link
Contributor

@Thihup this seems to have caused a significant regression. Please see #855 - I am hoping we can resolve the issue without needing to revert it. Please share your thoughts.

We would like to release 0.24.0, but we need to resolve or revert this change before we can do that. @Thihup are you able to review the issue raised in #855 so we can proceed?

@Thihup
Copy link
Contributor Author

Thihup commented Jan 27, 2025

@Thihup this seems to have caused a significant regression. Please see #855 - I am hoping we can resolve the issue without needing to revert it. Please share your thoughts.

We would like to release 0.24.0, but we need to resolve or revert this change before we can do that. @Thihup are you able to review the issue raised in #855 so we can proceed?

Hi. I am currently unable to fix it. Reverting it is fine for me.

jonahgraham added a commit to jonahgraham/lsp4j that referenced this issue Jan 31, 2025
@jonahgraham
Revert "Add module-info to the modules"
cab02e8 
This reverts commit 7ce4f59 which
was part of PR eclipse-lsp4j#843

This reversion is being done because the added module info
breaks development setup and as of now no one has wanted to
pickup the work of having module-info.

By reverting this commit we can release 0.24.0 with the same
metadata as 0.23.0 was released.

Part of eclipse-lsp4j#830
@jonahgraham jonahgraham mentioned this issue Jan 31, 2025
Merged
@jonahgraham jonahgraham removed this from the 0.24.0 milestone Jan 31, 2025
@jonahgraham jonahgraham linked a pull request Jan 31, 2025 that will close this issue
Revert "Add module-info to the modules" #868
Merged
jonahgraham added a commit that referenced this issue Jan 31, 2025
@jonahgraham
Revert "Add module-info to the modules" (#868)
10515b1 
This reverts commit 7ce4f59 which
was part of PR #843

This reversion is being done because the added module info
breaks development setup and as of now no one has wanted to
pickup the work of having module-info.

By reverting this commit we can release 0.24.0 with the same
metadata as 0.23.0 was released.

Part of #830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help_wanted
Projects
None yet
Milestone
No milestone
4 participants
@cdietrich @jonahgraham @nixel2007 @Thihup