-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: k8s:resource replaces template variables in provided fragments, k8s:helm doesn't. #410
fix: k8s:resource replaces template variables in provided fragments, k8s:helm doesn't. #410
Conversation
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
============================================
+ Coverage 36.29% 36.65% +0.35%
- Complexity 2344 2368 +24
============================================
Files 379 383 +4
Lines 18839 18867 +28
Branches 2756 2755 -1
============================================
+ Hits 6838 6915 +77
+ Misses 11181 11121 -60
- Partials 820 831 +11
Continue to review full report at Codecov.
|
6acadc8
to
fd3da68
Compare
fd3da68
to
69dafe9
Compare
kubernetes-maven-plugin/doc/src/main/asciidoc/inc/goals/build/_jkube-resource.adoc
Outdated
Show resolved
Hide resolved
…k8s:helm doesn't. - Moved logic from ResourceMojo to separate service - Fixed Resource generation, template placeholders are replaced only in aggregated YAML file (kubernetes.yml) not in individual resource files. - Placeholder/variable replacement can be turned off (jkube.interpolateTemplateParameters) - Fixed Helm chart generation, template placeholders are NOT replaced. Provided support for Parameters with no default value (values.yml) will only contain those which have a default. The rest of parameters can be specified with `--set` option - Added integration test to verify behavior for resource and helm YAML generation. Signed-off-by: Marc Nuri <[email protected]> WIP fix: k8s:resource replaces template variables in provided fragments, k8s:helm doesn't. - Moved logic from ResourceMojo to separate service - Fixed Resource generation, template placeholders are replaced only in aggregated YAML file (kubernetes.yml) not in individual resource files. - Placeholder/variable replacement can be turned off (jkube.interpolateTemplateParameters) - Fixed Helm chart generation, template placeholders are NOT replaced. Provided support for Parameters with no default value (values.yml) will only contain those which have a default. The rest of parameters can be specified with `--set` option - Added integration test to verify behavior for resource and helm YAML generation. Signed-off-by: Marc Nuri <[email protected]>
69dafe9
to
983b8a9
Compare
SonarCloud Quality Gate failed. 0 Bugs 41.9% Coverage The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. |
Description
Fixes: #327
not in individual resource files.
Provided support for Parameters with no default value (values.yml) will only contain those which have a default.
The rest of parameters can be specified with
--set
optionType of change
test, version modification, documentation, etc.)
Checklist