fix: Build strategy picked up from XML configuration and properties

[manusa]

Description

fix #334: Build strategy picked up from XML configuration and properties

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• I have read the contributing guidelines
• I signed-off my commit with a user that has signed the Eclipse Contributor Agreement
• I Added CHANGELOG entry
• I have implemented unit tests to cover my changes
• I have updated the documentation accordingly
• No new bugs, code smells, etc. in SonarCloud report
• I tested my code in Kubernetes
• I tested my code in OpenShift

[rohanKanojia]

strange, Does setting parameter in maven XML config doesn't set property too?

[manusa]

strange, Does setting parameter in maven XML config doesn't set property too?

Nope, it's the other way around. Setting a property (XML, command-line) will set the parameter given it's properly annotated `@Parameter(property="whatever")

[manusa]

There are probably a few more cases left around the code that weren't addressed in #248. It's really hard to tack down all of the properties that should be "shared" in a configuration since they are scattered all around and used in the most creative possible ways.

[codecov]

Codecov Report

Merging #335 into master will not change coverage.
The diff coverage is 50.00%.

@@            Coverage Diff            @@
##             master     #335   +/-   ##
=========================================
  Coverage     33.76%   33.76%           
  Complexity     2174     2174           
=========================================
  Files           364      364           
  Lines         18567    18567           
  Branches       2741     2740    -1     
=========================================
  Hits           6270     6270           
- Misses        11547    11548    +1     
+ Partials        750      749    -1     

Impacted Files	Coverage Δ	Complexity Δ
...be/maven/plugin/mojo/build/AbstractDockerMojo.java	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...ipse/jkube/kit/config/service/JKubeServiceHub.java	84.44% <100.00%> (+1.83%)	16.00 <3.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90136e0...76f7281. Read the comment docs.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

75.0% Coverage
0.0% Duplication

The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here