ParameterInformation.documentation is not populated in textDocument/signatureHelp

[yyoncho]

Reference: https://github.com/eclipse/eclipse.jdt.ls/blob/6a4834a81206d3001bd6b170047d4606a7c4909f/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/contentassist/SignatureHelpRequestor.java#L140

Also, in the new version of the spec the label might be [number, number] which is more precise since it removes ambiguity when you want to mark the active parameter in the signature label.

[fbricon]

@NikolasKomonen you wanna take a look?

[datho7561]

I'm interested in taking a look at this.

[datho7561]

VS Code seems to display both the method documentation and the parameter documentation with no separator between them when you provide both. I don't know how other clients will treat it, though.

It seems like a matter of preference which we support. If we want to be able to match what TypeScript is doing in VS Code, we could switch to the parameter documentation, but several other language servers like rust-analyzer and gopls just show the full method documentation like we currently have.

Personally, I like having the documentation for just the given parameter open when filling in the arguments for a function, because I can always hover the method name if I want the full documentation, but depending on how this works in other clients it might make more sense to stick with what we have.

I'll open a draft demonstrating the behaviour with just the parameter documentation.

[rgrunber]

If this allows us to enable some form of signature help description, it might be worth it. See redhat-developer/vscode-java#2404 (comment) .