add test for typeName

Signed-off-by: Shi Chen <[email protected]>
eclipse-jdtls · May 19, 2022 · a8d5a83 · a8d5a83
1 parent 6d21568
commit a8d5a83
Showing 1 changed file with 13 additions and 3 deletions.
diff --git a/....ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/GenerateAccessorsHandlerTest.java b/....ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/GenerateAccessorsHandlerTest.java
@@ -43,23 +43,32 @@ public void testResolveUnimplementedAccessors() throws JavaModelException {
 				"	private static String staticField = \"23434343\";\r\n" +
 				"	private final String finalField;\r\n" +
 				"	String name;\r\n" +
+				"	List<String> names;\r\n" +
 				"}"
 				, true, null);
 		//@formatter:on
 		AccessorField[] accessors = GenerateAccessorsHandler.getUnimplementedAccessors(unit.findPrimaryType());
 		assertNotNull(accessors);
-		assertEquals(3, accessors.length);
+		assertEquals(4, accessors.length);
 		assertEquals("staticField", accessors[0].fieldName);
 		assertTrue(accessors[0].isStatic);
 		assertTrue(accessors[0].generateGetter && accessors[0].generateSetter);
+		assertEquals("String", accessors[0].typeName);
 		assertEquals("finalField", accessors[1].fieldName);
 		assertFalse(accessors[1].isStatic);
 		assertTrue(accessors[1].generateGetter);
 		assertFalse(accessors[1].generateSetter);
+		assertEquals("String", accessors[1].typeName);
 		assertEquals("name", accessors[2].fieldName);
 		assertFalse(accessors[2].isStatic);
 		assertTrue(accessors[2].generateGetter);
 		assertTrue(accessors[2].generateSetter);
+		assertEquals("String", accessors[2].typeName);
+		assertEquals("names", accessors[3].fieldName);
+		assertFalse(accessors[3].isStatic);
+		assertTrue(accessors[3].generateGetter);
+		assertTrue(accessors[3].generateSetter);
+		assertEquals("List<String>", accessors[3].typeName);
 	}
 
 	@Test
@@ -88,6 +97,7 @@ public void testResolveUnimplementedAccessors_methodsExist() throws JavaModelExc
 		assertEquals("id", accessors[0].fieldName);
 		assertFalse(accessors[0].generateGetter);
 		assertTrue(accessors[0].generateSetter);
+		assertEquals("int", accessors[0].typeName);
 	}
 
 	@Test
@@ -162,7 +172,7 @@ public void testGenerateAccessorsAfterCursorPosition() throws ValidateEditExcept
 					, true, null);
 			//@formatter:on
 			IType classB = unit.getType("B");
-			Range cursor = CodeActionUtil.getRange(unit, "/*|*/"); 
+			Range cursor = CodeActionUtil.getRange(unit, "/*|*/");
 			generateAccessors(classB, cursor);
 
 			/* @formatter:off */
@@ -225,7 +235,7 @@ public void testGenerateAccessorsBeforeCursorPosition() throws ValidateEditExcep
 					, true, null);
 			//@formatter:on
 			IType classB = unit.getType("B");
-			Range cursor = CodeActionUtil.getRange(unit, "/*|*/"); 
+			Range cursor = CodeActionUtil.getRange(unit, "/*|*/");
 			generateAccessors(classB, cursor);
 
 			/* @formatter:off */