enable completion tests for DOMCompletionEngine #653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gayanper
commented
Jul 28, 2024
gayanper
commented
- tests.model.CompletionTests
- Set the source range of the parameter name Fixes eclipse-jdt#379 Signed-off-by: David Thompson <[email protected]>
+ implement equals/hashCode Fixes eclipse-jdtls#317
Signed-off-by: David Thompson <[email protected]>
Storing the diagnostics as they appear and adding them at the end in one go so the top level CompilationUnit is already there.
- small fix for element type in typebindings - implement `resolveWellKnownType` - implement `resolveField` - fix `getName` for array type bindings Signed-off-by: David Thompson <[email protected]>
- run the javac test bundle properly - report the findings so they can be seen in the Jenkins UI Signed-off-by: David Thompson <[email protected]>
- fix resolveWellKnownType - implement resolve constructor Signed-off-by: David Thompson <[email protected]>
Errors from javadoc look out of place for now. Maybe in the future if/when there are settings for each of them they can be switched back to errors depending on settings.
Prevents from searching in index which index is being built.
methods that are not declared in current file.
Signed-off-by: Rob Stryker <[email protected]>
…f for-loop Signed-off-by: Rob Stryker <[email protected]>
…assignment Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
…ensions Signed-off-by: Rob Stryker <[email protected]>
…yield statement Part 1 and 2 Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
…e-jdt#621) * Fix some bugs requiring == for multiple resolutions on a node Signed-off-by: Rob Stryker <[email protected]> * Cleanup Signed-off-by: Rob Stryker <[email protected]> --------- Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]>
Signed-off-by: David Thompson <[email protected]>
The main goal of this PR is to get the quick fix for the following case
working:
```java
public class MyClass extends java.util.List {
}
```
I needed to redo a lot of the type variable and method param/arg code in
order to accomplish this.
Signed-off-by: David Thompson <[email protected]>
* Report diagnostics for the unused imports & private members & local variables
- var in method without initializer (eg `var i;`) - attempt to invoke `.toString()` on a method that returns `int` Signed-off-by: David Thompson <[email protected]>
- Some additional problem id mappings encountered along the way Signed-off-by: David Thompson <[email protected]>
+ fix some pb mapping
- tests.model.CompletionTests
Comment on lines
+705
to
+714
| public ITypeBinding resolveBindings(IType type) { | ||
| ASTParser parser = ASTParser.newParser(AST.getJLSLatest()); | ||
| parser.setSource(type.getTypeRoot()); | ||
| parser.setBindingsRecovery(true); | ||
| parser.setResolveBindings(true); | ||
| parser.setStatementsRecovery(false); | ||
| CompilationUnit cu = (CompilationUnit) parser.createAST(null); | ||
| TypeDeclaration typeDecl = (TypeDeclaration) cu.findDeclaringNode(type.getKey()); | ||
| return typeDecl.resolveBinding(); | ||
| } |
There was a problem hiding this comment.
This would be a very expensive operation to reparse every compilation unit. Moreover, this wouldn't work with binary types. I don't think it's suitable here.
akurtakov
force-pushed
the
dom-with-javac
branch
from
612291f to
d1f814c
Compare
akurtakov
force-pushed
the
dom-with-javac
branch
from
2b02636 to
a40c063
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
2 times, most recently
from
13a7ce9 to
911e4b3
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
3 times, most recently
from
16bd705 to
9fb5696
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
7b4b9ad to
e230daa
Compare
rgrunber
force-pushed
the
dom-with-javac
branch
from
0575d89 to
6dd73f3
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
df710af to
fbcc030
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
2ad1e11 to
f45e071
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
2 times, most recently
from
7f5c20a to
87832d6
Compare
|
Something similar (maybe even that particular patch, I don't recall) was merged in some months ago so we have on CI the result of completion tests when using Javac+DOM. So this PR can now be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.