Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fill in record components in record declaration #399

Merged
merged 1 commit into from
May 19, 2024

Conversation

gayanper
Copy link

Process the record type declaration members and fill in the record components from the variable declaration into the jdt DOM.

package com.example;

public record Person(String name, int age) {
    
}

The record declaration should now have record components and syntax highlighting and variable name completion should work for record components also

@gayanper
Copy link
Author

gayanper commented May 17, 2024

@mickaelistria Let me know what you think, it was easy than I thought and still doubt the fix because it was easy to implement ;)

@gayanper
Copy link
Author

Also let me know if there are any javac conversion unit tests if I can update for this change @mickaelistria

@mickaelistria mickaelistria merged commit 3da323d into eclipse-jdtls:dom-with-javac May 19, 2024
3 of 5 checks passed
@mickaelistria
Copy link

Thank you!

@gayanper gayanper deleted the fix-records branch May 20, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants