Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#429] request response service builder #606

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Jan 24, 2025

Notes for Reviewer

Start the pull request with the file: doc/user-documentation/request-response.md In this document there are several UML diagrams that make the reviewer familiar with the used terminology and how the classes are depending on each other.

This pull request implements only the service builder for request response.

  • The service builder creates a static storage with the static config of the service
  • Afterwards, the dynamic config of the service is created
  • It contains a set of builder config options that are required to calculate the max number of samples of the client and server data segment

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Relates to #429

@elfenpiff elfenpiff requested a review from elBoberido January 24, 2025 17:36
@elfenpiff elfenpiff self-assigned this Jan 24, 2025
@elfenpiff elfenpiff force-pushed the iox2-429-request-response-service-builder branch 2 times, most recently from 806d844 to 8b909fe Compare January 24, 2025 19:05
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The easy 31 files are done

config/README.md Outdated Show resolved Hide resolved
iceoryx2/src/config.rs Show resolved Hide resolved
examples/rust/request_response/README.md Show resolved Hide resolved
… coverage only when nightly compiler is available
@elfenpiff elfenpiff force-pushed the iox2-429-request-response-service-builder branch from 2cb835d to 9f41339 Compare January 31, 2025 09:53
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major. Can also be fixed in one of the other open PRs related to request-response

elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this pull request Feb 5, 2025
@elfenpiff elfenpiff requested a review from elBoberido February 5, 2025 13:35
@elfenpiff elfenpiff merged commit 5b45d39 into eclipse-iceoryx:main Feb 5, 2025
47 checks passed
@elfenpiff elfenpiff deleted the iox2-429-request-response-service-builder branch February 5, 2025 14:08
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (5e0edcd) to head (9f41339).
Report is 45 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             main   #606       +/-   ##
=========================================
- Coverage   79.19%      0   -79.20%     
=========================================
  Files         200      0      -200     
  Lines       24124      0    -24124     
=========================================
- Hits        19105      0    -19105     
+ Misses       5019      0     -5019     

see 200 files with indirect coverage changes

elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants