Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#736 Use clang-10 in Github CI Sanitize workflow #802

Conversation

dkroenke
Copy link
Member

@dkroenke dkroenke commented May 20, 2021

Signed-off-by: Dietrich Krönke [email protected]

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Branch follows the naming format (iox-#123-this-is-a-branch)
  4. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  5. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  6. Relevant issues are linked
  7. Add sensible notes for the reviewer
  8. All checks have passed (except task-list-completed)
  9. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@dkroenke dkroenke added the bugfix Solves a bug label May 20, 2021
@dkroenke dkroenke self-assigned this May 20, 2021
@dkroenke dkroenke force-pushed the iox-#736-set-clang-version-in-github-ci branch from 7370f5f to 92f5bde Compare May 20, 2021 09:40
@dkroenke dkroenke requested review from elBoberido and elfenpiff May 20, 2021 09:46
@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #802 (92f5bde) into master (e6be1f7) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #802      +/-   ##
==========================================
+ Coverage   74.36%   74.41%   +0.05%     
==========================================
  Files         322      322              
  Lines       11522    11522              
  Branches     1952     1952              
==========================================
+ Hits         8568     8574       +6     
+ Misses       2194     2190       -4     
+ Partials      760      758       -2     
Flag Coverage Δ
unittests 73.24% <ø> (+0.05%) ⬆️
unittests_timing 30.91% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._hoofs/source/posix_wrapper/unix_domain_socket.cpp 61.37% <0.00%> (+1.71%) ⬆️
iceoryx_hoofs/source/concurrent/loffli.cpp 85.29% <0.00%> (+5.88%) ⬆️

@dkroenke dkroenke linked an issue May 20, 2021 that may be closed by this pull request
@dkroenke dkroenke merged commit eadf0ce into eclipse-iceoryx:master May 20, 2021
@dkroenke dkroenke deleted the iox-#736-set-clang-version-in-github-ci branch May 20, 2021 10:11
elBoberido added a commit that referenced this pull request May 25, 2021
…there-is-an-outdated-socket-release-v1.0

backport of iox-#654, iox-#791, iox-#802 and iox-#808 to release branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Solves a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build cyclone dds idlpp-cxx
3 participants