Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #670 release 0.99.5 #690

Merged

Conversation

dkroenke
Copy link
Member

@dkroenke dkroenke commented Apr 8, 2021

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Branch follows the naming format (iox-#123-this-is-a-branch)
  4. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  5. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  6. Relevant issues are linked
  7. Add sensible notes for the reviewer
  8. All checks have passed (except task-list-completed)
  9. Assign PR to reviewer

Notes for Reviewer

add libatomic dependency to package.xml of iceoryx_utils

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@dkroenke dkroenke requested review from budrus and elBoberido April 8, 2021 07:59
@dkroenke dkroenke requested a review from mossmaurice April 8, 2021 08:06
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #690 (1a2c9ea) into release_1.0 (d0ec578) will increase coverage by 0.64%.
The diff coverage is 84.31%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release_1.0     #690      +/-   ##
===============================================
+ Coverage        73.82%   74.47%   +0.64%     
===============================================
  Files              316      315       -1     
  Lines            11099    11213     +114     
  Branches          1952     1969      +17     
===============================================
+ Hits              8194     8351     +157     
+ Misses            2138     2084      -54     
- Partials           767      778      +11     
Flag Coverage Δ
unittests 74.43% <84.31%> (+0.65%) ⬆️
unittests_timing 31.11% <16.18%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ude/iceoryx_binding_c/internal/cpp2c_publisher.hpp 100.00% <ø> (ø)
...de/iceoryx_binding_c/internal/cpp2c_subscriber.hpp 100.00% <ø> (ø)
...nclude/iceoryx_dds/internal/gateway/iox_to_dds.inl 62.96% <0.00%> (ø)
...ude/iceoryx_posh/internal/mepoo/memory_manager.hpp 100.00% <ø> (ø)
...clude/iceoryx_posh/internal/mepoo/shared_chunk.hpp 100.00% <ø> (ø)
...nternal/popo/building_blocks/chunk_distributor.hpp 100.00% <ø> (ø)
...ternal/popo/building_blocks/chunk_queue_popper.hpp 100.00% <ø> (ø)
...ernal/popo/building_blocks/chunk_receiver_data.inl 100.00% <ø> (ø)
...osh/internal/popo/building_blocks/chunk_sender.hpp 100.00% <ø> (ø)
...nternal/popo/building_blocks/chunk_sender_data.inl 100.00% <ø> (ø)
... and 97 more

@dkroenke dkroenke merged commit 54b616b into eclipse-iceoryx:release_1.0 Apr 8, 2021
@dkroenke dkroenke deleted the iox-#670-release-0.99.5 branch April 8, 2021 08:24
marthtz pushed a commit to boschglobal/iceoryx that referenced this pull request May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants