Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare dependency on libatomic in package.xml #689

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Declare dependency on libatomic in package.xml #689

merged 1 commit into from
Apr 8, 2021

Conversation

cottsay
Copy link
Contributor

@cottsay cottsay commented Apr 8, 2021

This library is used here:

if(LINUX)
set(ICEORYX_PLATFORM ${CMAKE_CURRENT_SOURCE_DIR}/platform/linux/)
target_link_libraries(iceoryx_utils PRIVATE acl atomic ${CODE_COVERAGE_LIBS})

Here are the backing rosdep rules for libatomic: https://github.com/ros/rosdistro/blob/master/rosdep/base.yaml#L1856-L1861

The library is somehow implicitly installed for our Ubuntu builds, but it needs an explicit dependency for RHEL: https://build.ros2.org/job/Rbin_rhel_el864__iceoryx_utils__rhel_8_x86_64__binary/5/console

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #689 (70ed271) into master (c4270c9) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
+ Coverage   74.52%   74.54%   +0.01%     
==========================================
  Files         317      317              
  Lines       11224    11224              
  Branches     1970     1970              
==========================================
+ Hits         8365     8367       +2     
+ Misses       2081     2079       -2     
  Partials      778      778              
Flag Coverage Δ
unittests 74.50% <ø> (+0.01%) ⬆️
unittests_timing 31.18% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_utils/source/posix_wrapper/timer.cpp 59.64% <0.00%> (-0.88%) ⬇️
..._utils/source/posix_wrapper/unix_domain_socket.cpp 58.52% <0.00%> (+1.84%) ⬆️

@dkroenke dkroenke self-requested a review April 8, 2021 05:49
@budrus budrus self-requested a review April 8, 2021 07:32
@dkroenke dkroenke linked an issue Apr 8, 2021 that may be closed by this pull request
2 tasks
@dkroenke dkroenke added the bugfix Solves a bug label Apr 8, 2021
@dkroenke dkroenke merged commit 87ab00f into eclipse-iceoryx:master Apr 8, 2021
marthtz pushed a commit to boschglobal/iceoryx that referenced this pull request May 12, 2021
Declare dependency on libatomic in package.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Solves a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare package release for iceoryx 1.0
3 participants