-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #14 adjust untyped user header api #665
Merged
elBoberido
merged 6 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#14-adjust-untyped-user-header-API
Apr 1, 2021
Merged
Iox #14 adjust untyped user header api #665
elBoberido
merged 6 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#14-adjust-untyped-user-header-API
Apr 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…typed C++ API Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
…blisher Signed-off-by: Mathias Kraus <[email protected]>
…ublisher Signed-off-by: Mathias Kraus <[email protected]>
…yload Signed-off-by: Mathias Kraus <[email protected]>
571dacf
to
6968f8c
Compare
elfenpiff
previously approved these changes
Apr 1, 2021
Signed-off-by: Mathias Kraus <[email protected]>
FerdinandSpitzschnueffler
approved these changes
Apr 1, 2021
elfenpiff
approved these changes
Apr 1, 2021
Codecov Report
@@ Coverage Diff @@
## master #665 +/- ##
==========================================
+ Coverage 74.37% 74.39% +0.01%
==========================================
Files 319 318 -1
Lines 11207 11204 -3
Branches 1963 1963
==========================================
Hits 8335 8335
+ Misses 2100 2097 -3
Partials 772 772
Flags with carried forward coverage won't be shown. Click here to find out more.
|
marthtz
pushed a commit
to boschglobal/iceoryx
that referenced
this pull request
May 12, 2021
…yped-user-header-API Iox eclipse-iceoryx#14 adjust untyped user header api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
This PR refactors the user-header untyped API to be able to implement a gateway, which needs to set the user-header on a per sample base.
Additionally, the typed publisher/subscriber get an alias like the untyped ones in order to prevent the user from specifying a BasePublisher/BaseSubscriber.
Lastly,
ChunkHeader::userHeader
is now untyped likeChunkHeader::userPayload
. Later on we can introduceChunkHeader::userHeaderTyped
andChunkHeader::userPayloadTyped
if necessaryChecklist for the PR Reviewer
Post-review Checklist for the PR Author
References