Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iox-#346 Add copyright header check #347

Merged
merged 4 commits into from
Nov 10, 2020
Merged

Iox-#346 Add copyright header check #347

merged 4 commits into from
Nov 10, 2020

Conversation

jpsamper2009
Copy link
Contributor

Details

  • This PR uses ament_copyright to check that all source files contain an appropriate copyright header
  • Currently supported copyright headers can be found in the template directory
  • If in the future we need a copyright header different from those provided by ament_copyright, we may need to create a small python package that extends the available copyright headers
  • This PR also fixes certain copyright headers which had small typos which caused them to be flagged by the checker

@jpsamper2009
Copy link
Contributor Author

@elBoberido I'm not sure where the ECA check is getting the .ai email address from... everything is set up with the gmail account and the commits are signed with the email account too...

@mossmaurice
Copy link
Contributor

@elBoberido I'm not sure where the ECA check is getting the .ai email address from... everything is set up with the gmail account and the commits are signed with the email account too...

Have you doubled checked the email field under accounts.eclipse.org -> My Profile -> Edit Profile -> Account settings -> Email address?

If this is the right email address, I'll open a support ticket at https://bugs.eclipse.org/bugs/ for you.

elfenpiff
elfenpiff previously approved these changes Nov 10, 2020
View reviewed changes
@elBoberido
Copy link
Member

elBoberido commented Nov 10, 2020 •
edited
Loading

@jpsamper2009 I think I found the problem. This is what I see at a commit tab

 Juan Pablo Samper authored and jpsamper2009 committed 10 hours ago

If you hover the symbols to the left of that message you also see two different icons. It seems Juan Pablo Sampler has the apex.ai email address and the eca check is towards the author, not the committer.

@elBoberido elBoberido linked an issue Nov 10, 2020 that may be closed by this pull request
Check the files have a copyright header #346
Closed
marthtz
marthtz previously approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@marthtz marthtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have this in place!

@jpsamper2009 jpsamper2009 force-pushed the iox-346-add-copyright-check branch from c0c664e to b497145 Compare November 10, 2020 13:05
@jpsamper2009
Copy link
Contributor Author

@elBoberido Well I feel dumb... now this should be ready.

@mossmaurice mossmaurice merged commit 5b843ef into eclipse-iceoryx:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mossmaurice mossmaurice mossmaurice approved these changes

@elBoberido elBoberido elBoberido approved these changes

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler FerdinandSpitzschnueffler approved these changes

@marthtz marthtz marthtz left review comments

@elfenpiff elfenpiff elfenpiff left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check the files have a copyright header
6 participants
@jpsamper2009 @mossmaurice @elBoberido @marthtz @elfenpiff @FerdinandSpitzschnueffler