-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#1032 replace 'IOX_EXPECTS'/'IOX_ENSURES' with 'IOX_ENFORCE' #2181
iox-#1032 replace 'IOX_EXPECTS'/'IOX_ENSURES' with 'IOX_ENFORCE' #2181
Conversation
49eb12d
to
00cebf6
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2181 +/- ##
==========================================
- Coverage 80.06% 79.97% -0.10%
==========================================
Files 421 420 -1
Lines 16361 16362 +1
Branches 2270 2275 +5
==========================================
- Hits 13099 13085 -14
- Misses 2419 2439 +20
+ Partials 843 838 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @budrus @elfenpiff feel free to add yourself as reviewer |
00cebf6
to
12bd135
Compare
… iox::string in MessageQueue" This reverts commit 890848f.
By default, the MessageQueue class relies on std::string objects to send and receive data, as defined by its interface. However, this approach can potentially lead to dynamic memory allocation when handling larger data payloads that exceed the stack space optimization (SSO) limit. To address this issue, an alternative API has been introduced that enables data transmission and reception using iox::string. This approach allows for direct data manipulation within stack memory, effectively eliminating the need for dynamic memory allocation. Signed-off-by: Luca Bartoli <[email protected]>
12bd135
to
6c945a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks...
Pre-Review Checklist for the PR Author
[ ] Changelog updated in the unreleased section including API breaking changesiox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
This PR replaces the legacy error handler macros ('IOX_ENFORCE' and 'IOX_EXPECTS') with the new
IOX_ENFORCE
macro and adjusts the tests. Additionally, the error output is improved.The changelog will be updated with the next PR which also removes all the TODOs and updates the error handling md files.
Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References