Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1391 Move remaining concurrent classes to new location #2143

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Dec 23, 2023

Pre-Review Checklist for the PR Author

  1. Add a second reviewer for complex new features or larger refactorings
  2. Code follows the coding style of CONTRIBUTING.md
  3. Tests follow the best practice for testing
  4. Changelog updated in the unreleased section including API breaking changes
  5. Branch follows the naming format (iox-123-this-is-a-branch)
  6. Commits messages are according to this guideline
  7. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  8. Relevant issues are linked
  9. Add sensible notes for the reviewer
  10. All checks have passed (except task-list-completed)
  11. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  12. Assign PR to reviewer

Notes for Reviewer

This PR moves the smart_lock and PeriodicTask to the new module structure.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added refactoring Refactor code without adding features technical debt unclean code and design flaws labels Dec 23, 2023
@elBoberido elBoberido self-assigned this Dec 23, 2023
Copy link

codecov bot commented Dec 23, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fe3ef2e) 80.11% compared to head (d211c66) 80.22%.
Report is 8 commits behind head on master.

❗ Current head d211c66 differs from pull request most recent head e003168. Consider uploading reports for the commit e003168 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2143      +/-   ##
==========================================
+ Coverage   80.11%   80.22%   +0.10%     
==========================================
  Files         418      418              
  Lines       16218    16169      -49     
  Branches     2251     2255       +4     
==========================================
- Hits        12993    12971      -22     
+ Misses       2420     2399      -21     
+ Partials      805      799       -6     
Flag Coverage Δ
unittests 80.01% <97.43%> (+0.10%) ⬆️
unittests_timing 15.26% <42.30%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...de/iox/detail/mpmc_lockfree_queue/cyclic_index.inl 100.00% <ø> (ø)
...ox/detail/mpmc_lockfree_queue/mpmc_index_queue.inl 84.21% <100.00%> (ø)
...detail/mpmc_lockfree_queue/mpmc_lockfree_queue.inl 98.24% <100.00%> (ø)
..._lockfree_queue/mpmc_resizeable_lockfree_queue.inl 90.41% <100.00%> (ø)
...ncurrent/buffer/include/iox/detail/mpmc_loffli.hpp 100.00% <100.00%> (ø)
...ncurrent/buffer/include/iox/detail/mpmc_loffli.inl 100.00% <100.00%> (ø)
...lude/iox/detail/mpmc_resizeable_lockfree_queue.hpp 100.00% <100.00%> (ø)
...concurrent/buffer/include/iox/detail/spsc_fifo.inl 100.00% <100.00%> (ø)
...concurrent/buffer/include/iox/detail/spsc_sofi.hpp 100.00% <100.00%> (ø)
...concurrent/buffer/include/iox/detail/spsc_sofi.inl 89.47% <100.00%> (ø)
... and 15 more

... and 16 files with indirect coverage changes

@elBoberido elBoberido changed the title [Based on #2142] iox-#1391 Move remaining concurrent classes to new location iox-#1391 Move remaining concurrent classes to new location Jan 2, 2024
@elBoberido elBoberido force-pushed the iox-1391-move-hoofs-header-from-legacy-path-to-module-path-part-8 branch from d211c66 to e003168 Compare January 2, 2024 20:54
@elBoberido elBoberido marked this pull request as ready for review January 2, 2024 20:56
@elBoberido elBoberido requested a review from elfenpiff January 2, 2024 20:56
@elBoberido elBoberido merged commit 8c32765 into eclipse-iceoryx:master Jan 2, 2024
22 checks passed
@elBoberido elBoberido deleted the iox-1391-move-hoofs-header-from-legacy-path-to-module-path-part-8 branch January 2, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features technical debt unclean code and design flaws
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants