Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1533 Standalone roudi environment #2021

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Sep 6, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

This PR creates a separate package for the RouDiEnvironment which does not depend on gTest and can also be build without the tests. This is important for the Rust bindings since they need the RouDi environment for its own tests but not the iceoryx C++ tests which take quite long to build.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added enhancement New feature refactoring Refactor code without adding features technical debt unclean code and design flaws labels Sep 6, 2023
@elBoberido elBoberido self-assigned this Sep 6, 2023
@elBoberido elBoberido changed the title iox-#1533 Standalone roudi environment [Draft: depends on 2020] iox-#1533 Standalone roudi environment Sep 6, 2023
@elBoberido elBoberido force-pushed the iox-1533-standalone-roudi-environment branch from 8a33650 to 7cc7cb0 Compare September 6, 2023 19:43
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #2021 (dd72966) into master (b1f39df) will decrease coverage by 0.07%.
The diff coverage is 78.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2021      +/-   ##
==========================================
- Coverage   74.31%   74.24%   -0.07%     
==========================================
  Files         413      417       +4     
  Lines       16198    16290      +92     
  Branches     2257     2277      +20     
==========================================
+ Hits        12037    12094      +57     
- Misses       3437     3458      +21     
- Partials      724      738      +14     
Flag Coverage Δ
unittests 74.03% <78.37%> (-0.07%) ⬇️
unittests_timing 15.03% <2.70%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...posh/include/iceoryx_posh/runtime/posh_runtime.hpp 100.00% <ø> (ø)
...de/iceoryx_posh/roudi_env/minimal_roudi_config.hpp 0.00% <ø> (ø)
...ryx_posh/roudi_env/source/minimal_roudi_config.cpp 100.00% <ø> (ø)
...x_posh/roudi_env/source/runtime_test_interface.cpp 50.00% <ø> (ø)
iceoryx_posh/source/roudi/port_manager.cpp 84.02% <66.66%> (ø)
iceoryx_posh/roudi_env/source/roudi_env.cpp 75.00% <75.00%> (ø)
...osh/source/popo/building_blocks/locking_policy.cpp 61.29% <100.00%> (ø)
...osh/source/popo/building_blocks/unique_port_id.cpp 88.88% <100.00%> (-2.78%) ⬇️
iceoryx_posh/source/roudi/roudi.cpp 59.57% <100.00%> (ø)
iceoryx_posh/source/runtime/posh_runtime_impl.cpp 64.10% <100.00%> (ø)

... and 1 file with indirect coverage changes

@elBoberido elBoberido force-pushed the iox-1533-standalone-roudi-environment branch 3 times, most recently from 667fe19 to 1b378db Compare September 7, 2023 19:14
@elBoberido elBoberido force-pushed the iox-1533-standalone-roudi-environment branch from 1b378db to ddbabb1 Compare September 20, 2023 12:20
@elBoberido elBoberido marked this pull request as ready for review September 20, 2023 12:20
@elBoberido elBoberido changed the title [Draft: depends on 2020] iox-#1533 Standalone roudi environment iox-#1533 Standalone roudi environment Sep 20, 2023
Copy link
Contributor

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but maybe @dkroenke could have a look at the cmake and bazel files.

@elBoberido
Copy link
Member Author

@mossmaurice @dkroenke @MatthiasKillat @elfenpiff

I came to the conclusion that it was not one of my brightest moments to add all the committer as reviewer since everybody would think that another one would already review. My new approach is now to ping all the committer in a comment and the ones who like to do the review can add themself as reviewer. I hope this makes it more clear when a PR has sufficient reviewers :)

@elBoberido elBoberido force-pushed the iox-1533-standalone-roudi-environment branch from 962e7c7 to dd72966 Compare September 21, 2023 12:17
@MatthiasKillat MatthiasKillat self-requested a review September 22, 2023 09:20
@elBoberido elBoberido merged commit 4fb0b5f into eclipse-iceoryx:master Sep 22, 2023
@elBoberido elBoberido deleted the iox-1533-standalone-roudi-environment branch September 22, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature refactoring Refactor code without adding features technical debt unclean code and design flaws
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roudi Environment independent from Googletest
3 participants