-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#1533 Standalone roudi environment #2021
iox-#1533 Standalone roudi environment #2021
Conversation
8a33650
to
7cc7cb0
Compare
Codecov Report
@@ Coverage Diff @@
## master #2021 +/- ##
==========================================
- Coverage 74.31% 74.24% -0.07%
==========================================
Files 413 417 +4
Lines 16198 16290 +92
Branches 2257 2277 +20
==========================================
+ Hits 12037 12094 +57
- Misses 3437 3458 +21
- Partials 724 738 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
667fe19
to
1b378db
Compare
1b378db
to
ddbabb1
Compare
iceoryx_posh/roudi_env/include/iceoryx_posh/roudi_env/minimal_roudi_config.hpp
Show resolved
Hide resolved
iceoryx_posh/roudi_env/include/iceoryx_posh/roudi_env/roudi_env.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but maybe @dkroenke could have a look at the cmake and bazel files.
iceoryx_posh/include/iceoryx_posh/internal/popo/building_blocks/unique_port_id.hpp
Outdated
Show resolved
Hide resolved
@mossmaurice @dkroenke @MatthiasKillat @elfenpiff I came to the conclusion that it was not one of my brightest moments to add all the committer as reviewer since everybody would think that another one would already review. My new approach is now to ping all the committer in a comment and the ones who like to do the review can add themself as reviewer. I hope this makes it more clear when a PR has sufficient reviewers :) |
962e7c7
to
dd72966
Compare
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
This PR creates a separate package for the
RouDiEnvironment
which does not depend ongTest
and can also be build without the tests. This is important for the Rust bindings since they need the RouDi environment for its own tests but not the iceoryx C++ tests which take quite long to build.Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References