Add relocatable pointers #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
mossmaurice
approved these changes
Dec 12, 2019
Comment on lines
+60
to
+61
| // we let the OS decide where to map the shm segments | ||
| constexpr void* BASE_ADDRESS_HINT{nullptr}; |
There was a problem hiding this comment.
Could we save some pointer arithmetic by giving the operating system a hint that will mostly work for all applications? I could imagine the performance might be slightly better if there is no offset.
@elBoberido @elfenpiff Are there any performance measurements w/ and w/o relocatable pointer?
Comment on lines
+40
to
+41
| // we let the OS decide where to map the shm segments | ||
| constexpr void* BASE_ADDRESS_HINT{nullptr}; |
|
|
||
| /// @todo this is a temporary dummy variable to keep the size of the ChunkHeader at 64 byte for compatibility | ||
| /// reasons | ||
| void* m_payloadDummy{nullptr}; |
Comment on lines
+29
to
31
| /// @todo since we are now fully relocatable, this can be removed | ||
| uintptr_t m_sharedMemoryBaseAddressOffset = 0; | ||
| bool m_verifySharedMemoryPlacement = false; |
There was a problem hiding this comment.
Can you create a follow-up issue for this?
Comment on lines
+105
to
106
| /// @todo the best guess mapping address as long as we do not have introduced relative pointers | ||
| defaultConfig.roudi.m_sharedMemoryBaseAddressOffset = 0x3E80000000ull; |
There was a problem hiding this comment.
Please either remove it or use it as a hint.
Comment on lines
+34
to
+35
| // we let the OS decide where to map the shm segments | ||
| constexpr void* BASE_ADDRESS_HINT{nullptr}; |
budrus
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19
Signed-off-by: Hintz Martin (CC-AD/ESW1) [email protected]