iox-#1969 align iox expected to std expected and add convenience free functions #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elBoberido
added
bugfix
elBoberido
force-pushed
the
iox-1969-align-iox-expected-to-std-expected-and-add-convenience-free-functions
branch
from
1720ed6 to
af7f994
Compare
Codecov Report
@@ Coverage Diff @@
## master #1981 +/- ##
==========================================
- Coverage 74.23% 74.13% -0.11%
==========================================
Files 413 405 -8
Lines 16067 15942 -125
Branches 2250 2242 -8
==========================================
- Hits 11928 11818 -110
+ Misses 3425 3413 -12
+ Partials 714 711 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
elfenpiff
approved these changes
May 5, 2023
mossmaurice
reviewed
Jun 5, 2023
| @@ -51,7 +51,7 @@ class FunctionalInterface_test : public testing::Test | |||
| }; | |||
|
|
|||
| /// @brief This types is used for testing the functional interface in the case | |||
| /// of a value and a get_error method | |||
| /// of a 'value' and a 'error' method | |||
| using DummyValueType = bool; | ||
| static constexpr DummyValueType DUMMY_VALUE{true}; | ||
|
|
||
| iox::variant<DummyValueType, ErrorType> data; |
There was a problem hiding this comment.
I think that should be enough, right?
Suggested change
| iox::variant<DummyValueType, ErrorType> data; | |
| variant<DummyValueType, ErrorType> data; |
There was a problem hiding this comment.
The additional namespace does not hurt :)
| /// @brief helper struct to create an expected which is signalling success more easily | ||
| /// @param T type which the success helper class should contain | ||
| template <typename T = void> | ||
| using success = detail::ok<T>; |
There was a problem hiding this comment.
Shouldn't this be deprecated?
mossmaurice
approved these changes
Jun 6, 2023
|
Sorry, all relevant copyright header are updated. A mass search and replace does not warrant an update of the copyright header. |
elBoberido
deleted the
iox-1969-align-iox-expected-to-std-expected-and-add-convenience-free-functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch)iox-#123 commit text)task-list-completed)iceoryx_hoofsare added to./clang-tidy-diff-scans.txtNotes for Reviewer
This PR aligns the
iox::expectedbetter to thestd::expectedexpected<E>in favor ofexpected<void, E>get_errorwitherrorhas_valueokanderrorfree functionsunexpect_thelper struct for direct initializationChecklist for the PR Reviewer
Copyright owner are updated in the changed filesiceoryx_hoofshave been added to./clang-tidy-diff-scans.txtPost-review Checklist for the PR Author
References
expected<void, Error>is unusable due tofinal#1976