iox-#1969 rework constructors for expected

[elBoberido]

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
11. Assign PR to reviewer

Notes for Reviewer

This PR adds the in_place_t direct constructors for the expected to better align with the std::expected

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Relates to Better align 'iox::expected' with 'std::expected' #1969

[codecov]

Codecov Report

Merging #1970 (18adcee) into master (e7b572b) will decrease coverage by 0.31%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1970      +/-   ##
==========================================
- Coverage   74.50%   74.20%   -0.31%     
==========================================
  Files         401      401              
  Lines       15809    15814       +5     
  Branches     2225     2225              
==========================================
- Hits        11779    11734      -45     
- Misses       3322     3376      +54     
+ Partials      708      704       -4     

Flag	Coverage Δ
unittests	74.20% <100.00%> (+0.02%)	⬆️
unittests_timing	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
iceoryx_hoofs/vocabulary/include/iox/expected.hpp	100.00% <ø> (ø)
...x_hoofs/vocabulary/include/iox/detail/expected.inl	97.22% <100.00%> (+0.09%)	⬆️

... and 7 files with indirect coverage changes

[mossmaurice]

Thanks, the changes look good.

One Q: Wouldn't it make sense to deprecate create_value and create_error right away on this PR?

[elBoberido]

Thanks, the changes look good.

One Q: Wouldn't it make sense to deprecate create_value and create_error right away on this PR?

No, I would wait till unexpect_t is available