Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1934 Alias invoke_result to correct implementation based on C++ version #1956

Merged

Conversation

albtam
Copy link
Contributor

@albtam albtam commented Apr 3, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. [ ] Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

result_of has been deprecated in C++17 and removed in C++20

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@albtam albtam force-pushed the iox-1934-using-invoke-result branch from 322f980 to d42eaca Compare April 3, 2023 15:43
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Could you please add this also to the other platforms?

@albtam albtam force-pushed the iox-1934-using-invoke-result branch from d42eaca to 40692fe Compare April 3, 2023 15:54
@albtam
Copy link
Contributor Author

albtam commented Apr 3, 2023

Nice. Could you please add this also to the other platforms?

Done

@albtam albtam force-pushed the iox-1934-using-invoke-result branch from 40692fe to df3f3b6 Compare April 3, 2023 16:02
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. From my point of view this can be merged once the ECA check is green.

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #1956 (df3f3b6) into master (207d419) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1956      +/-   ##
==========================================
- Coverage   75.51%   75.51%   -0.01%     
==========================================
  Files         388      388              
  Lines       15276    15276              
  Branches     2158     2158              
==========================================
- Hits        11536    11535       -1     
  Misses       3067     3067              
- Partials      673      674       +1     
Flag Coverage Δ
unittests 75.17% <ø> (-0.01%) ⬇️
unittests_timing 15.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@elBoberido elBoberido merged commit b013052 into eclipse-iceoryx:master Apr 3, 2023
@elBoberido elBoberido deleted the iox-1934-using-invoke-result branch April 3, 2023 17:07
@elBoberido
Copy link
Member

@albtam welcome to the iceoryx contributor gang :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken build: std::result_of is removed in C++20
4 participants