-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#1934 Alias invoke_result to correct implementation based on C++ version #1956
iox-#1934 Alias invoke_result to correct implementation based on C++ version #1956
Conversation
322f980
to
d42eaca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Could you please add this also to the other platforms?
d42eaca
to
40692fe
Compare
Done |
iceoryx_platform/linux/include/iceoryx_platform/platform_settings.hpp
Outdated
Show resolved
Hide resolved
…n based on C++ version
40692fe
to
df3f3b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. From my point of view this can be merged once the ECA check is green.
Codecov Report
@@ Coverage Diff @@
## master #1956 +/- ##
==========================================
- Coverage 75.51% 75.51% -0.01%
==========================================
Files 388 388
Lines 15276 15276
Branches 2158 2158
==========================================
- Hits 11536 11535 -1
Misses 3067 3067
- Partials 673 674 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
@albtam welcome to the iceoryx contributor gang :) |
Pre-Review Checklist for the PR Author
[ ] Tests follow the best practice for testingiox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
result_of
has been deprecated in C++17 and removed in C++20Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References