Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-1391 move primitives files #1899

Conversation

FerdinandSpitzschnueffler
Copy link
Contributor

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler commented Feb 15, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

See PR title.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #1899 (c30c2c3) into master (697adc9) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1899      +/-   ##
==========================================
- Coverage   75.45%   75.44%   -0.02%     
==========================================
  Files         383      383              
  Lines       15181    15181              
  Branches     2148     2148              
==========================================
- Hits        11455    11453       -2     
- Misses       3055     3056       +1     
- Partials      671      672       +1     
Flag Coverage Δ
unittests 75.10% <100.00%> (-0.02%) ⬇️
unittests_timing 15.43% <28.57%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...clude/iceoryx_dust/internal/cli/option_manager.inl 0.00% <ø> (ø)
...e/iceoryx_dust/internal/cxx/std_string_support.inl 100.00% <ø> (ø)
iceoryx_dust/source/cli/command_line_parser.cpp 0.00% <ø> (ø)
iceoryx_hoofs/buffer/include/iox/stack.hpp 100.00% <ø> (ø)
...oofs/container/include/iox/uninitialized_array.hpp 100.00% <ø> (ø)
iceoryx_hoofs/container/include/iox/vector.hpp 100.00% <ø> (ø)
...design/include/iox/detail/functional_interface.inl 95.12% <ø> (ø)
...ryx_hoofs/concurrent/resizeable_lockfree_queue.hpp 100.00% <ø> (ø)
...include/iceoryx_hoofs/internal/concurrent/sofi.hpp 100.00% <ø> (ø)
...e/iceoryx_hoofs/internal/cxx/storable_function.hpp 100.00% <ø> (ø)
... and 33 more

Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but you approved a PR which now causes merge conflicts in this one

@FerdinandSpitzschnueffler
Copy link
Contributor Author

Looks good but you approved a PR which now causes merge conflicts in this one

@elBoberido I rebased and removed a superfluous include path in the BumpAllocator.

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler merged commit 2f87030 into eclipse-iceoryx:master Feb 16, 2023
@FerdinandSpitzschnueffler FerdinandSpitzschnueffler deleted the iox-1391-move-primitives-files branch February 16, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
globex refactoring Refactor code without adding features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split iceoryx_hoofs into logical modules
3 participants