-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-1391 move primitives files #1899
iox-1391 move primitives files #1899
Conversation
33c4449
to
54e9598
Compare
Codecov Report
@@ Coverage Diff @@
## master #1899 +/- ##
==========================================
- Coverage 75.45% 75.44% -0.02%
==========================================
Files 383 383
Lines 15181 15181
Branches 2148 2148
==========================================
- Hits 11455 11453 -2
- Misses 3055 3056 +1
- Partials 671 672 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but you approved a PR which now causes merge conflicts in this one
Signed-off-by: Marika Lehmann <[email protected]>
Signed-off-by: Marika Lehmann <[email protected]>
Signed-off-by: Marika Lehmann <[email protected]>
Signed-off-by: Marika Lehmann <[email protected]>
54e9598
to
c30c2c3
Compare
@elBoberido I rebased and removed a superfluous include path in the |
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
See PR title.
Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References
iceoryx_hoofs
into logical modules #1391 (partially)