Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1736 use clang format 15 in ci #1737

Merged

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Oct 13, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

Ported from #1656 in the hope to also fix #1731. Locally I could not reproduce the pre-flight-check failure with clang-format-15.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #1737 (0b59b5a) into master (0bd5a36) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1737      +/-   ##
==========================================
- Coverage   77.44%   77.40%   -0.04%     
==========================================
  Files         366      366              
  Lines       14169    14169              
  Branches     1983     1983              
==========================================
- Hits        10973    10968       -5     
- Misses       2569     2571       +2     
- Partials      627      630       +3     
Flag Coverage Δ
unittests 77.06% <ø> (-0.04%) ⬇️
unittests_timing 15.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../include/iceoryx_posh/internal/gateway/channel.inl 88.88% <ø> (ø)
iceoryx_hoofs/source/concurrent/loffli.cpp 74.28% <0.00%> (-11.43%) ⬇️
...oofs/include/iceoryx_hoofs/internal/cxx/string.inl 98.47% <0.00%> (-0.39%) ⬇️

@FerdinandSpitzschnueffler
Copy link
Contributor

@elBoberido Your last commit message is not signed. Otherwise it looks fine.

@elBoberido
Copy link
Member Author

elBoberido commented Oct 13, 2022

@FerdinandSpitzschnueffler I tell you a dirty little secret. I NEVER sign my commits. It isn't required by eclipse anymore and therefore I skip this. Maybe we should also remove this from our PR template.

@elBoberido elBoberido removed the request for review from mossmaurice October 13, 2022 11:36
@FerdinandSpitzschnueffler
Copy link
Contributor

@FerdinandSpitzschnueffler I tell you a dirty little secret. I NEVER sign my commits. It isn't required by eclipse anymore and therefore I skip this. Maybe we should also remove this from our PR template.

I wasn't aware of this. Then we definitely should remove this item from our template.

@elBoberido elBoberido merged commit 82df77d into eclipse-iceoryx:master Oct 13, 2022
@elBoberido elBoberido deleted the iox-1736-use-clang-format-15-in-CI branch October 13, 2022 11:49
@elBoberido
Copy link
Member Author

@FerdinandSpitzschnueffler I'll do that in my next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Solves a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI uses outdated clang-format
4 participants