-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#1736 use clang format 15 in ci #1737
iox-#1736 use clang format 15 in ci #1737
Conversation
Signed-off-by: Dietrich Krönke <[email protected]>
Signed-off-by: Dietrich Krönke <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1737 +/- ##
==========================================
- Coverage 77.44% 77.40% -0.04%
==========================================
Files 366 366
Lines 14169 14169
Branches 1983 1983
==========================================
- Hits 10973 10968 -5
- Misses 2569 2571 +2
- Partials 627 630 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@elBoberido Your last commit message is not signed. Otherwise it looks fine. |
@FerdinandSpitzschnueffler I tell you a dirty little secret. I NEVER sign my commits. It isn't required by eclipse anymore and therefore I skip this. Maybe we should also remove this from our PR template. |
I wasn't aware of this. Then we definitely should remove this item from our template. |
@FerdinandSpitzschnueffler I'll do that in my next PR |
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
Ported from #1656 in the hope to also fix #1731. Locally I could not reproduce the pre-flight-check failure with clang-format-15.
Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References