-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#1196 Introduce and fix warnings in posh tests #1455
iox-#1196 Introduce and fix warnings in posh tests #1455
Conversation
Signed-off-by: Marika Lehmann <[email protected]>
4b78cdf
to
463524d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I am just not sure about the pid_t
change.
@@ -47,20 +47,34 @@ class MockTriggeHandle | |||
return *this; | |||
} | |||
|
|||
#ifdef __clang__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The more I see this #pragma
sequence the more I think we should define some abbreviation macro for this (or let the compiler ignore it on a global level if possible. Can be decided in a separate PR though, fine for now.
463524d
to
0eaad7a
Compare
0eaad7a
to
c16b426
Compare
c16b426
to
8367f50
Compare
Signed-off-by: Marika Lehmann <[email protected]>
8367f50
to
de29541
Compare
Codecov Report
@@ Coverage Diff @@
## master #1455 +/- ##
==========================================
- Coverage 78.75% 78.75% -0.01%
==========================================
Files 377 377
Lines 14490 14490
Branches 2011 2011
==========================================
- Hits 11412 11411 -1
- Misses 2438 2439 +1
Partials 640 640
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
This PR introduces the warnings in CMakeLists.txt for posh tests and fixes them.
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References