Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1196 Introduce and fix warnings in posh tests #1455

Conversation

FerdinandSpitzschnueffler
Copy link
Contributor

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler commented Jul 6, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

This PR introduces the warnings in CMakeLists.txt for posh tests and fixes them.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler added bugfix Solves a bug technical debt unclean code and design flaws labels Jul 6, 2022
@FerdinandSpitzschnueffler FerdinandSpitzschnueffler requested review from elfenpiff and removed request for mossmaurice July 6, 2022 13:00
@FerdinandSpitzschnueffler FerdinandSpitzschnueffler force-pushed the iox-#1196-fix-compiler-warnings-in-posh branch from 4b78cdf to 463524d Compare July 6, 2022 13:26
Copy link
Contributor

@MatthiasKillat MatthiasKillat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I am just not sure about the pid_t change.

@@ -47,20 +47,34 @@ class MockTriggeHandle
return *this;
}

#ifdef __clang__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more I see this #pragma sequence the more I think we should define some abbreviation macro for this (or let the compiler ignore it on a global level if possible. Can be decided in a separate PR though, fine for now.

iceoryx_posh/test/moduletests/test_popo_publisher.cpp Outdated Show resolved Hide resolved
@FerdinandSpitzschnueffler FerdinandSpitzschnueffler force-pushed the iox-#1196-fix-compiler-warnings-in-posh branch from 463524d to 0eaad7a Compare July 6, 2022 13:49
elfenpiff
elfenpiff previously approved these changes Jul 6, 2022
MatthiasKillat
MatthiasKillat previously approved these changes Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #1455 (de29541) into master (1e1ac61) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1455      +/-   ##
==========================================
- Coverage   78.75%   78.75%   -0.01%     
==========================================
  Files         377      377              
  Lines       14490    14490              
  Branches     2011     2011              
==========================================
- Hits        11412    11411       -1     
- Misses       2438     2439       +1     
  Partials      640      640              
Flag Coverage Δ
unittests 78.41% <ø> (-0.01%) ⬇️
unittests_timing 14.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_hoofs/source/concurrent/loffli.cpp 80.00% <0.00%> (-5.72%) ⬇️
...e/iceoryx_hoofs/internal/concurrent/smart_lock.inl 94.33% <0.00%> (+1.88%) ⬆️

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler merged commit e608798 into eclipse-iceoryx:master Jul 6, 2022
@FerdinandSpitzschnueffler FerdinandSpitzschnueffler deleted the iox-#1196-fix-compiler-warnings-in-posh branch July 6, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Solves a bug technical debt unclean code and design flaws
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable clang-tidy checks and fix warnings in code
3 participants