Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1196 Fix compiler warnings in binding c tests #1452

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Jul 6, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Part of #1196

@elfenpiff elfenpiff self-assigned this Jul 6, 2022
@mossmaurice
Copy link
Contributor

mossmaurice commented Jul 6, 2022

@elfenpiff Thanks for the PR! 🚀 There are some build errors on Ubuntu.

@mossmaurice mossmaurice added the refactoring Refactor code without adding features label Jul 6, 2022
@elfenpiff elfenpiff force-pushed the iox-#1196-fix-compiler-warnings-in-binding-c-tests branch from ebdb15f to 5d240ac Compare July 6, 2022 09:49
@elfenpiff elfenpiff force-pushed the iox-#1196-fix-compiler-warnings-in-binding-c-tests branch from 5d240ac to 9f98548 Compare July 6, 2022 10:03
@elfenpiff elfenpiff requested a review from MatthiasKillat July 6, 2022 10:12
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #1452 (9f98548) into master (1e1ac61) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1452      +/-   ##
==========================================
+ Coverage   78.75%   78.77%   +0.02%     
==========================================
  Files         377      377              
  Lines       14490    14490              
  Branches     2011     2011              
==========================================
+ Hits        11412    11415       +3     
+ Misses       2438     2437       -1     
+ Partials      640      638       -2     
Flag Coverage Δ
unittests 78.44% <ø> (+0.02%) ⬆️
unittests_timing 14.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_posh/source/roudi/port_manager.cpp 84.42% <0.00%> (+0.18%) ⬆️
iceoryx_hoofs/source/concurrent/loffli.cpp 91.42% <0.00%> (+5.71%) ⬆️

@elfenpiff elfenpiff merged commit 02eb68c into eclipse-iceoryx:master Jul 6, 2022
@elfenpiff elfenpiff deleted the iox-#1196-fix-compiler-warnings-in-binding-c-tests branch July 6, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants