Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1287 Fix CMake install paths #1385

Merged

Conversation

mossmaurice
Copy link
Contributor

@mossmaurice mossmaurice commented Jun 8, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

  • Avoid duplicate installation of iceoryx_posh without /iceoryx/v2.90.0/
$ tree build/install/prefix/ -L 2
.
├── bin
├── etc
├── include
│   ├── iceoryx
│   │   └── v2.90.0
│   └── iceoryx_posh # This is the duplication, already contained in the folder above
├── lib
└── share
    └── doc

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@mossmaurice mossmaurice added the tooling All iceoryx related tooling (scripts etc.) label Jun 8, 2022
@mossmaurice mossmaurice self-assigned this Jun 8, 2022
@mossmaurice mossmaurice changed the title iox-#1287 fix cmake install paths iox-#1287 Fix CMake install paths Jun 8, 2022
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #1385 (9624b70) into master (6a11ba3) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1385      +/-   ##
==========================================
- Coverage   78.81%   78.79%   -0.03%     
==========================================
  Files         375      375              
  Lines       14555    14555              
  Branches     2030     2030              
==========================================
- Hits        11472    11469       -3     
- Misses       2425     2426       +1     
- Partials      658      660       +2     
Flag Coverage Δ
unittests 78.46% <ø> (-0.03%) ⬇️
unittests_timing 14.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_hoofs/source/concurrent/loffli.cpp 85.71% <0.00%> (-5.72%) ⬇️
...e/iceoryx_hoofs/internal/concurrent/smart_lock.inl 92.45% <0.00%> (-1.89%) ⬇️

@mossmaurice mossmaurice force-pushed the iox-#1287-fix-cmake-install-paths branch from 45ca0d8 to 9624b70 Compare June 9, 2022 14:38
@mossmaurice mossmaurice marked this pull request as ready for review June 9, 2022 16:27
@mossmaurice mossmaurice merged commit 96de86c into eclipse-iceoryx:master Jun 10, 2022
@mossmaurice mossmaurice deleted the iox-#1287-fix-cmake-install-paths branch June 10, 2022 13:16
@elBoberido elBoberido linked an issue Jun 10, 2022 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling All iceoryx related tooling (scripts etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting RPATH for iceoryx artifacts
3 participants