Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #743 fix windows c waitset example #1284

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Mar 11, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elfenpiff elfenpiff changed the base branch from master to release_2.0 March 11, 2022 14:52
@elfenpiff elfenpiff self-assigned this Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #1284 (f98f7ad) into master (afdaa82) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1284      +/-   ##
==========================================
- Coverage   78.92%   78.91%   -0.02%     
==========================================
  Files         370      370              
  Lines       14706    14705       -1     
  Branches     2059     2059              
==========================================
- Hits        11607    11604       -3     
- Misses       2418     2419       +1     
- Partials      681      682       +1     
Flag Coverage Δ
unittests 78.14% <100.00%> (-0.02%) ⬇️
unittests_timing 15.49% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_posh/source/roudi/port_manager.cpp 84.24% <100.00%> (-0.03%) ⬇️
iceoryx_hoofs/source/concurrent/loffli.cpp 80.00% <0.00%> (-11.43%) ⬇️
...nternal/roudi/introspection/port_introspection.inl 82.84% <0.00%> (+0.72%) ⬆️

@elBoberido
Copy link
Member

Please change the target branch to master

@elfenpiff elfenpiff changed the base branch from release_2.0 to master March 14, 2022 10:01
@elfenpiff elfenpiff requested a review from elBoberido March 14, 2022 10:01
elBoberido
elBoberido previously approved these changes Mar 14, 2022
@elBoberido elBoberido dismissed their stale review March 14, 2022 12:50

Further changes needed

…yright year and readme

Signed-off-by: Christian Eltzschig <[email protected]>
@elfenpiff elfenpiff force-pushed the iox-#743-fix-windows-c-waitset-example branch from 903c470 to f98f7ad Compare March 14, 2022 14:48
@elfenpiff elfenpiff merged commit 608dda8 into eclipse-iceoryx:master Mar 15, 2022
@elfenpiff elfenpiff deleted the iox-#743-fix-windows-c-waitset-example branch March 15, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants